From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993102AbWJUPjL (ORCPT ); Sat, 21 Oct 2006 11:39:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2993107AbWJUPjL (ORCPT ); Sat, 21 Oct 2006 11:39:11 -0400 Received: from stinky.trash.net ([213.144.137.162]:13813 "EHLO stinky.trash.net") by vger.kernel.org with ESMTP id S2993102AbWJUPjK (ORCPT ); Sat, 21 Oct 2006 11:39:10 -0400 Message-ID: <453A3F0C.3000406@trash.net> Date: Sat, 21 Oct 2006 17:38:52 +0200 From: Patrick McHardy User-Agent: Debian Thunderbird 1.0.7 (X11/20051017) X-Accept-Language: en-us, en MIME-Version: 1.0 To: htejun@gmail.com CC: jeff@garzik.org, Linux Kernel Mailing List Subject: "libata: fix non-uniform ports handling" breaks sata_sis secondary port X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The patch "libata: fix non-uniform ports handling" breaks the secondary SATA port with the sata_sis driver for me (no link detected). The reason seems to be that the SIS_FLAG_CFGSCR flag is only set on probe_ent->port_flags in sis_init_one(), but ata_port_init() uses ent->pinfo2->flags for initialization of the flags in struct ata_port for the secondary port. lspci entry of the controller below, if more information is needed please ask. 0000:00:05.0 RAID bus controller: Silicon Integrated Systems [SiS] RAID bus controller 180 SATA/PATA [SiS] (rev 01) (prog-if 85) Subsystem: ASUSTeK Computer Inc.: Unknown device 810e Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR-