From: "bibo,mao" <bibo_mao@linux.intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "bibo,mao" <bibo.mao@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix minor error about efi memory_present
Date: Mon, 23 Oct 2006 13:52:42 +0800 [thread overview]
Message-ID: <453C58AA.6070307@linux.intel.com> (raw)
In-Reply-To: <20061022214508.6c4f30c6.akpm@osdl.org>
Andrew Morton wrote:
> On Mon, 23 Oct 2006 11:42:33 +0800
> "bibo,mao" <bibo.mao@intel.com> wrote:
>
>> Hi,
>> Function efi_memory_present_wrapper parameter start/end is physical address,
>> but function memory_present parameter is PFN, this patch converts physical
>> address to PFN.
>>
>> Signed-off-by: bibo, mao <bibo.mao@intel.com>
>>
>> thanks
>> bibo,mao
>>
>> diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
>> index 519e63c..141041d 100644
>> --- a/arch/i386/kernel/setup.c
>> +++ b/arch/i386/kernel/setup.c
>> @@ -846,7 +846,7 @@ efi_find_max_pfn(unsigned long start, un
>> static int __init
>> efi_memory_present_wrapper(unsigned long start, unsigned long end, void *arg)
>> {
>> - memory_present(0, start, end);
>> + memory_present(0, PFN_UP(start), PFN_DOWN(end));
>> return 0;
>> }
>>
>
> It doesn't _seem_ like a "minor error". How come people's machines haven't
> been crashing all over the place?
This patch is only efi bios relative, most machines in the market are
legacy bios. System only crashes when booting from EFI bios.
thanks
bibo,mao
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2006-10-23 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 3:42 [PATCH] fix minor error about efi memory_present bibo,mao
2006-10-23 4:45 ` Andrew Morton
2006-10-23 5:52 ` bibo,mao [this message]
2006-10-23 8:36 ` [PATCH] vmalloc : optimization, cleanup, bugfixes Eric Dumazet
2006-10-23 9:13 ` Nick Piggin
2006-10-23 9:30 ` Eric Dumazet
2006-10-30 20:42 ` Zwane Mwaikambo
2006-10-30 21:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453C58AA.6070307@linux.intel.com \
--to=bibo_mao@linux.intel.com \
--cc=akpm@osdl.org \
--cc=bibo.mao@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox