public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmalloc : optimization, cleanup, bugfixes
Date: Mon, 23 Oct 2006 19:13:10 +1000	[thread overview]
Message-ID: <453C87A6.4060602@yahoo.com.au> (raw)
In-Reply-To: <200610231036.10418.dada1@cosmosbay.com>

Eric Dumazet wrote:
> [PATCH] vmalloc : optimization, cleanup, bugfixes
> 
> This patch does three things
> 
> 1) reorder 'struct vm_struct' to speedup lookups on CPUS with small cache 
> lines. The fields 'next,addr,size' should be now in the same cache line, to 
> speedup lookups.
> 
> 2) One minor cleanup in __get_vm_area_node()
> 
> 3) Bugfixes in vmalloc_user() and vmalloc_32_user()
> NULL returns from __vmalloc() and __find_vm_area() were not tested.

Hmm, so they weren't. As far as testing the return of __find_vm_area,
you can just turn that into a BUG_ON(!area), because at that point,
we've established that the vmalloc succeeded.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

  reply	other threads:[~2006-10-23  9:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-23  3:42 [PATCH] fix minor error about efi memory_present bibo,mao
2006-10-23  4:45 ` Andrew Morton
2006-10-23  5:52   ` bibo,mao
2006-10-23  8:36   ` [PATCH] vmalloc : optimization, cleanup, bugfixes Eric Dumazet
2006-10-23  9:13     ` Nick Piggin [this message]
2006-10-23  9:30       ` Eric Dumazet
2006-10-30 20:42       ` Zwane Mwaikambo
2006-10-30 21:09         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453C87A6.4060602@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox