* [PATCH] Function v9fs_get_idpool returns int, not u32 as called twice in fs/9p/vfs_inode.c
@ 2006-10-25 19:28 Mika Kukkonen
0 siblings, 0 replies; only message in thread
From: Mika Kukkonen @ 2006-10-25 19:28 UTC (permalink / raw)
To: v9fs-developer; +Cc: linux-kernel
|[V9FS] Function v9fs_get_idpool returns int, not u32. Actually
it returns -1 on errors, and these two callers check if
the value is smaller than 0, which was caught by gcc with
extra warning flags. Compile tested only but should be OK,
as the value computed in v9fs_get_idpool() is also int.
Signed-of-by: Mika Kukkonen <mikukkon@iki.fi>
---
fs/9p/vfs_inode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 5241c60..18f26cd 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -256,7 +256,7 @@ static int
v9fs_create(struct v9fs_session_info *v9ses, u32 pfid, char *name, u32 perm,
u8 mode, char *extension, u32 *fidp, struct v9fs_qid *qid, u32 *iounit)
{
- u32 fid;
+ int fid;
int err;
struct v9fs_fcall *fcall;
@@ -310,7 +310,7 @@ static struct v9fs_fid*
v9fs_clone_walk(struct v9fs_session_info *v9ses, u32 fid, struct dentry *dentry)
{
int err;
- u32 nfid;
+ int nfid;
struct v9fs_fid *ret;
struct v9fs_fcall *fcall;
|
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-10-25 19:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-25 19:28 [PATCH] Function v9fs_get_idpool returns int, not u32 as called twice in fs/9p/vfs_inode.c Mika Kukkonen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox