From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, Peter Williams <pwil3058@bigpond.net.au>,
linux-kernel@vger.kernel.org, "Siddha,
Suresh B" <suresh.b.siddha@intel.com>, Dave Chinner <dgc@sgi.com>,
Ingo Molnar <mingo@elte.hu>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 2/5] Extract load calculation from rebalance_tick
Date: Thu, 26 Oct 2006 22:03:16 +1000 [thread overview]
Message-ID: <4540A404.5090406@yahoo.com.au> (raw)
In-Reply-To: <20061024183114.4530.95231.sendpatchset@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> Extract load calculation from rebalance_tick
>
> A load calculation is always done in rebalance_tick() in addition
> to the real load balancing activities that only take place when certain
> jiffie counts have been reached. Move that processing into a separate
> function and call it directly from scheduler_tick().
Ack for this one.
>
> Also extract the time slice handling from scheduler_tick and
> put it into a separate function. Then we can clean up scheduler_tick
> significantly. It will no longer have any gotos.
'time_slice' should be static, and it should be named better, and you
may as well also put the "task has expired but not rescheduled" part
in there too. That is part of the same logical op (which is to resched
the task when it finishes timeslice).
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-10-26 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 18:31 [PATCH 0/5] On demand sched_domain balancing in tasklet Christoph Lameter
2006-10-24 18:31 ` [PATCH 1/5] Disable interrupts for locking in load_balance() Christoph Lameter
2006-10-24 18:31 ` [PATCH 2/5] Extract load calculation from rebalance_tick Christoph Lameter
2006-10-26 12:03 ` Nick Piggin [this message]
2006-10-26 16:12 ` Christoph Lameter
2006-10-24 18:31 ` [PATCH 3/5] Use next_balance instead of last_balance Christoph Lameter
2006-10-26 12:13 ` Nick Piggin
2006-10-26 12:32 ` Nick Piggin
2006-10-26 16:44 ` Christoph Lameter
2006-10-26 17:13 ` Nick Piggin
2006-10-26 18:17 ` Christoph Lameter
2006-10-24 18:31 ` [PATCH 4/5] Create rebalance_domains from rebalance_tick Christoph Lameter
2006-10-26 12:19 ` Nick Piggin
2006-10-26 16:19 ` Christoph Lameter
2006-10-24 18:31 ` [PATCH 5/5] Only call rebalance_domains when needed from scheduler_tick Christoph Lameter
2006-10-26 12:26 ` Nick Piggin
2006-10-26 16:24 ` Christoph Lameter
2006-10-26 17:12 ` Nick Piggin
2006-10-26 18:13 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4540A404.5090406@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=dgc@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pwil3058@bigpond.net.au \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox