From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423461AbWJZMcV (ORCPT ); Thu, 26 Oct 2006 08:32:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423463AbWJZMcV (ORCPT ); Thu, 26 Oct 2006 08:32:21 -0400 Received: from smtp103.mail.mud.yahoo.com ([209.191.85.213]:55679 "HELO smtp103.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S1423461AbWJZMcT (ORCPT ); Thu, 26 Oct 2006 08:32:19 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=SHPlOclLKZqpvwsX2atsTGzF4jIVVWz7lWR02/32MJmsX7IHCDEjNuQFgP3Ud3tFYnWysnUYEE/RToi9OmdxX2KccOu5A0A+RVvF3BUhrXr2Xvmp+C5Ft0fgBypiAYF53XPi4bhf1SXuRFythgGmHrYe0wnAYFmY0HdI0fcSpuM= ; Message-ID: <4540AACE.3010804@yahoo.com.au> Date: Thu, 26 Oct 2006 22:32:14 +1000 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1 X-Accept-Language: en MIME-Version: 1.0 CC: Christoph Lameter , akpm@osdl.org, Peter Williams , linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki , Dave Chinner , Ingo Molnar , "Siddha, Suresh B" Subject: Re: [PATCH 3/5] Use next_balance instead of last_balance References: <20061024183104.4530.29183.sendpatchset@schroedinger.engr.sgi.com> <20061024183119.4530.64973.sendpatchset@schroedinger.engr.sgi.com> <4540A676.1070802@yahoo.com.au> In-Reply-To: <4540A676.1070802@yahoo.com.au> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Nick Piggin wrote: > Christoph Lameter wrote: > >> Use next_balance instead of last_balance ... >> >> The cpu offset calculation in the sched_domains code makes it >> difficult to >> figure out when the next event is supposed to happen since we only keep >> track of the last_balancing. We want to know when the next load balance >> is supposed to occur. >> >> Move the cpu offset calculation into build_sched_domains(). Do the >> setup of the staggered load balance schewduling when the sched domains >> are initialized. That way we dont have to worry about it anymore later. >> >> This also in turn simplifies the load balancing time checks. > > > OK. I think I made this overcomplex in order to cope with issues where > offset can get skewed so if we're unlucky they might all get into synch > ... but this new code isn't any worse than the old, and it is cheaper. > > So, Ack. Actually, it is wrong, so nack. You didn't take into account that balance_interval may have changed, and so might the idle status. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com