Re: [PATCH 2/5] Extract load calculation from rebalance_tick

Nick Piggin
2006-10-26T12:03:35Z

Christoph Lameter wrote:
> Extract load calculation from rebalance_tick
>
> A load calculation is always done in rebalance_tick() in addition
> to the real load balancing activities that only take place when certain
> jiffie counts have been reached. Move that processing into a separate
> function and call it directly from scheduler_tick().

Ack for this one.

>
> Also extract the time slice handling from scheduler_tick and
> put it into a separate function. Then we can clean up scheduler_tick
> significantly. It will no longer have any gotos.

'time_slice' should be static, and it should be named better, and you
may as well also put the "task has expired but not rescheduled" part
in there too. That is part of the same logical op (which is to resched
the task when it finishes timeslice).

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com