Re: [PATCH cciss: fix printk format warning

[Randy Dunlap <randy.dunlap@oracle.com>]

Randy Dunlap wrote:
> Roland Dreier wrote:
>>  > >      if (*total_size != (__u32) 0)
>>  >  > Why is cciss_read_capacity casting *total_size to u32?
>>
>> It's not -- it's actually casting 0 to __32 -- there's no cast on the
>> *total_size side of the comparison.  However that just makes the cast
>> look even fishier.
>>
>>  - R.
> 
> OK, how about this one then?
> 
> 
>     c->busaddr = (__u32) cmd_dma_handle;
> 
> where cmd_dma_handle is a dma_addr_t (u32 or u64)
> 
> and then later:
> 
>         pci_free_consistent(h->pdev, sizeof(CommandList_struct),
>                     c, (dma_addr_t) c->busaddr);
> 

One problem with this one is that it looks like the hardware
wants a 32-bit value for busaddr:

cciss.h:         writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);

-- 
~Randy