public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix bug in fs/ecryptfs/inode.c: ecryptfs_encode_filename() returns int, not unsigned int
@ 2006-10-27  7:48 Mika Kukkonen
  0 siblings, 0 replies; only message in thread
From: Mika Kukkonen @ 2006-10-27  7:48 UTC (permalink / raw)
  To: ecryptfs-devel; +Cc: akpm, linux-kernel

[PATCH] Fix bug in fs/ecryptfs/inode.c: ecryptfs_encode_filename()
        returns int (with possible negative error value), not
        unsigned int. Both callers in the file get it wrong (they
        are also the only callers of this function). Found by gcc
        extra warning flags (the return value is checked to be < 0,
        which is pointless with unsigned). Compile tested only, but
        should be OK, as the value computed in the function
        internally is int too.

Signed-off-by: Mika Kukkonen <mikukkon@iki.fi>

---

 fs/ecryptfs/inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index efdd2b7..692419c 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -338,7 +338,7 @@ static struct dentry *ecryptfs_lookup(st
     struct vfsmount *lower_mnt;
     struct dentry *tlower_dentry = NULL;
     char *encoded_name;
-    unsigned int encoded_namelen;
+    int encoded_namelen;
     struct ecryptfs_crypt_stat *crypt_stat = NULL;
     char *page_virt = NULL;
     struct inode *lower_inode;
@@ -520,7 +520,7 @@ static int ecryptfs_symlink(struct inode
     struct dentry *lower_dir_dentry;
     umode_t mode;
     char *encoded_symname;
-    unsigned int encoded_symlen;
+    int encoded_symlen;
     struct ecryptfs_crypt_stat *crypt_stat = NULL;

     lower_dentry = ecryptfs_dentry_to_lower(dentry);



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-27  7:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-27  7:48 [PATCH] Fix bug in fs/ecryptfs/inode.c: ecryptfs_encode_filename() returns int, not unsigned int Mika Kukkonen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox