From: Zach Brown <zach.brown@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dio: lock refcount operations
Date: Fri, 27 Oct 2006 16:34:22 -0700 [thread overview]
Message-ID: <4542977E.5030007@oracle.com> (raw)
In-Reply-To: <x49odrxnyyt.fsf@segfault.boston.devel.redhat.com>
> zach.brown> The addition of the interrupt masking spin lock acquiry in
> zach.brown> dio_bio_submit() looks alarming. This lock acquiry existed in
> zach.brown> that path before the recent dio completion patch set. We
> zach.brown> shouldn't expect significant performance regression from
> zach.brown> returning to the behaviour that existed before the completion
> zach.brown> clean up work.
>
> Are you going to quantify this at all? I think we should.
I could try to take a swing at it next week, sure.
Leaving it for Ken is pretty tempting, though :)
- z
next prev parent reply other threads:[~2006-10-27 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-27 18:17 [PATCH] dio: lock refcount operations Zach Brown
2006-10-27 19:27 ` Jeff Moyer
2006-10-27 20:34 ` Zach Brown
2006-10-27 23:03 ` Jeff Moyer
2006-10-27 23:34 ` Zach Brown [this message]
2006-11-02 1:51 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4542977E.5030007@oracle.com \
--to=zach.brown@oracle.com \
--cc=akpm@osdl.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox