public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: gnome-terminal acts funny in recent 2.5 series
@ 2002-02-19 14:08 ALESSANDRO.SUARDI
  0 siblings, 0 replies; 10+ messages in thread
From: ALESSANDRO.SUARDI @ 2002-02-19 14:08 UTC (permalink / raw)
  To: hirofumi; +Cc: linux-kernel, davem

OGAWA Hirofumi wrote:
> 
> Alessandro Suardi <alessandro.suardi@oracle.com> writes:
> 
>> Running Ximian-latest for rh72/i386, latest 2.5 kernels (including
>>   2.5.4-pre2, 2.5.4, 2.5.5-pre1).
>> 
>> Symptom:
>>    - clicking on the panel icon for gnome-terminal shows a flicker
>>       of the terminal window coming up then the window disappears.
>>      No leftover processes.

[snip]

> Probably, this problem had occurred in libzvt which gnome-terminal 
> is using.
> 
> libzvt was using file descriptor passing via UNIX domain socket for
> pseudo terminal. Then because ->passcred was not initialized in
> sock_alloc(), unexpected credential data was passing to libzvt.
> 
> The following patch fixed this problem, but I'm not sure.
> Could you review the patch? (attached file are test program)
> 
> --- socket.c.orig     Mon Feb 11 18:21:59 2002
> +++ socket.c     Tue Feb 19 16:20:18 2002
> @@ -501,6 +501,8 @@ struct socket *sock_alloc(void)
>      sock->ops = NULL;
>      sock->sk = NULL;
>      sock->file = NULL;
> +//     init_waitqueue_head(&sock->wait);     this is needed?
> +     sock->passcred = 0;
> 
>      sockets_in_use[smp_processor_id()].counter++;
>      return sock;

Success on first attempt - thanks. Of course since this wasn't
 fully reproducable I'll assume the patch fixes the bug, unless
 proven wrong.

Thanks again,

--alessandro

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: gnome-terminal acts funny in recent 2.5 series
@ 2002-02-19 16:40 Petr Vandrovec
  2002-02-19 17:47 ` OGAWA Hirofumi
  0 siblings, 1 reply; 10+ messages in thread
From: Petr Vandrovec @ 2002-02-19 16:40 UTC (permalink / raw)
  To: OGAWA Hirofumi; +Cc: linux-kernel, David S. Miller

On 19 Feb 02 at 20:44, OGAWA Hirofumi wrote:
> 
> libzvt was using file descriptor passing via UNIX domain socket for
> pseudo terminal. Then because ->passcred was not initialized in
> sock_alloc(), unexpected credential data was passing to libzvt.
> 
> The following patch fixed this problem, but I'm not sure.
> Could you review the patch? (attached file are test program)

I sent simillar patch to Linus and DaveM on Sunday. Unfortunately it
did not found its way into either of these two trees (and IPX oops fix too). 
In addition to yours I moved these 'sock->XXX = NULL' into sock_alloc_inode,
as I see no reason why sock->wait should be initialized in sock_alloc_inode,
but all other members in sock_alloc. It caused confusion to me, and
from your comment it looks like that you missed it too. Besides that
root of sockfs uses sock's inode with sock->ops, sk and file being
0x5a5a5a5a without moving initialization from sock_alloc to sock_alloc_inode.

> --- socket.c.orig   Mon Feb 11 18:21:59 2002
> +++ socket.c    Tue Feb 19 16:20:18 2002
> @@ -501,6 +501,8 @@ struct socket *sock_alloc(void)
>     sock->ops = NULL;
>     sock->sk = NULL;
>     sock->file = NULL;
> +// init_waitqueue_head(&sock->wait);   this is needed?
> +   sock->passcred = 0;
>  
>     sockets_in_use[smp_processor_id()].counter++;
>     return sock;

                                  Best regards,
                                                    Petr Vandrovec
                                                    vandrove@vc.cvut.cz
                                                    

^ permalink raw reply	[flat|nested] 10+ messages in thread
* gnome-terminal acts funny in recent 2.5 series
@ 2002-02-19  0:03 Alessandro Suardi
  2002-02-19  0:39 ` Gustavo Noronha Silva
  2002-02-19 11:44 ` OGAWA Hirofumi
  0 siblings, 2 replies; 10+ messages in thread
From: Alessandro Suardi @ 2002-02-19  0:03 UTC (permalink / raw)
  To: linux-kernel

Running Ximian-latest for rh72/i386, latest 2.5 kernels (including
  2.5.4-pre2, 2.5.4, 2.5.5-pre1).

Symptom:
   - clicking on the panel icon for gnome-terminal shows a flicker
      of the terminal window coming up then the window disappears.
     No leftover processes.

What works 100%:
   - regular xterm in 2.5.x
   - gnome-terminal in 2.4.x (x in .17, .18-pre9, .18-rc2)

More info:
   - doesn't happen 100% of the time, but close
   - trying to start gnome-terminal either vanilla or with the
      parameters in the icon from an xterm causes
       * gnome-terminal window comes up, but no shell prompt; the
          window *does not* disappear and program is in a CPU loop
       * program detaches from calling xterm even when '&' is
          not used
       * calling xterm's tty is left in a funny state (sometimes
          stty sane^J is required, sometimes tput reset)

Any ideas would be quite welcome - I can go back and try and narrow
  down what kernel breaks gnome-terminal if nothing comes up.


Thanks,

--alessandro

  "If your heart is a flame burning brightly
    you'll have light and you'll never be cold
   And soon you will know that you just grow / You're not growing old"
                               (Husker Du, "Flexible Flyer")


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2002-02-19 17:48 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-02-19 14:08 gnome-terminal acts funny in recent 2.5 series ALESSANDRO.SUARDI
  -- strict thread matches above, loose matches on Subject: below --
2002-02-19 16:40 Petr Vandrovec
2002-02-19 17:47 ` OGAWA Hirofumi
2002-02-19  0:03 Alessandro Suardi
2002-02-19  0:39 ` Gustavo Noronha Silva
2002-02-19  4:00   ` Wayne Whitney
2002-02-19 12:48     ` Sebastian Dröge
2002-02-19  6:13   ` Sebastian Dröge
2002-02-19 11:44 ` OGAWA Hirofumi
2002-02-19 15:09   ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox