From: Balbir Singh <balbir@in.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>,
Shailabh Nagar <nagar@watson.ibm.com>, Jay Lan <jlan@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] taskstats_tgid_free: fix usage
Date: Tue, 31 Oct 2006 08:19:32 +0530 [thread overview]
Message-ID: <4546B9BC.6020109@in.ibm.com> (raw)
In-Reply-To: <20061026232128.GA526@oleg>
Oleg Nesterov wrote:
> taskstats_tgid_free() is called on copy_process's error path. This is wrong.
>
> IF (clone_flags & CLONE_THREAD)
> We should not clear ->signal->taskstats, current uses it,
> it probably has a valid accumulated info.
> ELSE
> taskstats_tgid_init() set ->signal->taskstats = NULL,
> there is nothing to free.
>
> Move the callsite to __exit_signal(). We don't need any locking, entire
> thread group is exiting, nobody should have a reference to soon to be
> released ->signal.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Looks good!
Acked-by: Balbir Singh <balbir@in.ibm.com>
---
Balbir Singh,
Linux Technology Center,
IBM Software Labs
prev parent reply other threads:[~2006-10-31 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 23:21 [PATCH 3/6] taskstats_tgid_free: fix usage Oleg Nesterov
2006-10-31 2:49 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4546B9BC.6020109@in.ibm.com \
--to=balbir@in.ibm.com \
--cc=akpm@osdl.org \
--cc=jlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@watson.ibm.com \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox