From: Jeff Garzik <jgarzik@pobox.com>
To: Peer Chen <pchen@nvidia.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c
Date: Wed, 01 Nov 2006 04:47:51 -0500 [thread overview]
Message-ID: <45486D47.9020803@pobox.com> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B0C54F590@hkemmail01.nvidia.com>
Peer Chen wrote:
> Attached the patch cause my mail client always wrap the plain text format.
> Check attachment for patch,thanks.
Need one more modification:
It is the libata policy to prefer use of numeric hexidecimal constants
for the PCI device id, rather than always defining a symbol in
include/linux/pci_ids.h. The PCI device ID is a single-use "magic
number" that is only used in the PCI ID table.
Therefore, when your patch changes the hex numbers to constants, it is
reversing that policy.
Instead, please submit a patch that simply adds more hexidecimal PCI
device ids.
Jeff
next parent reply other threads:[~2006-11-01 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15F501D1A78BD343BE8F4D8DB854566B0C54F590@hkemmail01.nvidia.com>
2006-11-01 9:47 ` Jeff Garzik [this message]
2006-11-01 10:04 ` [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c Peer Chen
2006-11-01 10:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45486D47.9020803@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox