Re: [PATCH] Updated, add get_range, allows a hyhpenated range to get_options

[Randy Dunlap <randy.dunlap@oracle.com>]

Derek Fults wrote:
> On Wed, 2006-11-01 at 11:52 -0800, Randy Dunlap wrote:
>> Derek Fults wrote:
>>> This allows a hyphenated range of positive numbers M-N, in the string
>>> passed to command line helper function, get_options.  This will expand
>>> the range and insert the values[M, M+1, ..., N] into the ints array in
>>> get_options.
>>>
>>> Currently the command line option "isolcpus=" takes as its argument a
>>> list of cpus.  
>>> Format: <cpu number>,...,<cpu number>
>>> This can get extremely long when isolating the majority of cpus on a
>>> large system.  Valid values of <cpu_number>  include all cpus, 0 to
>>> "number of CPUs in system - 1".
>>>
>>>
>>> Signed-off-by: Derek Fults <dfults@sgi.com>  
>>>
>>> Index: linux/lib/cmdline.c
>>> ===================================================================
>>> --- linux.orig/lib/cmdline.c	2006-09-19 22:42:06.000000000 -0500
>>> +++ linux/lib/cmdline.c	2006-11-01 12:36:20.059166727 -0600
>>> @@ -16,6 +16,23 @@
>>>  #include <linux/kernel.h>
>>>  #include <linux/string.h>
>>>  
>>> +/**
>>> + *	If a hyphen was found in get_option, this will handle the
>>> + *	range of numbers, M-N.  This will expand the range and insert
>>> + *	the values[M, M+1, ..., N] into the ints array in get_options.
>>> + */
>> Derek,
>> Thanks for persisting thru this.  It's all fine for me except the
>> comment block above.  If a comment block begins with "/**", then
>> it's supposed to be in kernel-doc format (see
>> Documentation/kernel-doc-nano-HOWTO.txt), with function name &
>> parameters (if applicable).  However, that mostly needs to be done
>> for non-static functions, so probably just change /** to /*
>> and leave the rest of the comment block as is.
>> My other comment-block comment was also about kernel long-comment
>> style, which is
>> /*
>>  * begin
>>  * more
>>  * end
>>  */
>> so now you have achieved that also, so thanks again.
> 
> I fixed both comments to match that format.  Thanks for all the help and
> your patience.
> I'm posting the new patch in this replay.  Is that an acceptable
> practice, or does one normally post all fixes to a patch in a new
> message?

It happens both ways, but since this is mostly new code/feature,
I suggest that you repost it and also cc: akpm@osdl.org on it.

And it still needs a user.  Will you be converting isolcpus=
to use this functionality?
It likely won't be merged until it has a user.

-- 
~Randy