Re: [PATCH 1/2] taskstats: factor out reply assembling

Balbir Singh
2006-11-02T13:45:04Z

Oleg Nesterov wrote:
> On 11/02, Balbir Singh wrote:
>> Oleg Nesterov wrote:
>>> +
>>> + aggr = TASKSTATS_TYPE_AGGR_TGID;
>>> + if (type == TASKSTATS_TYPE_PID)
>>> + aggr = TASKSTATS_TYPE_AGGR_PID;
>> How about using
>>
>> aggr = (type == TASKSTATS_TYPE_PID) ? TASKSTATS_TYPE_AGGR_PID :
>> TASKSTATS_TYPE_AGGR_TGID;
>
> I personally think this is much better. In fact, i did exactly same, but
> then changed it because (I think) CodingStyle police doesn't like '?:'.
>
> Or it does?
>
> Oleg.
>

There is an issue with double assignment if the type is TASKSTATS_TYPE_PID most
of the time. I see the '?' operator in several places in the code.

--

Balbir Singh,
Linux Technology Center,
IBM Software Labs