From: William D Waddington <william.waddington@beezmo.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] IRQ: ease out-of-tree migration to new irq_handler prototype
Date: Sat, 04 Nov 2006 10:29:37 -0800 [thread overview]
Message-ID: <454CDC11.5030708@beezmo.com> (raw)
From: william.waddington@beezmo.com
Ease out-of-tree driver migration to new irq_handler prototype.
Define empty 3rd argument macro for use in multi kernel version
out-of-tree drivers going forward. Backportable drives can do:
(in a header)
#ifndef __PT_REGS
# define __PT_REGS , struct pt_regs *regs
#endif
(in code body)
static irqreturn_t irq_handler(int irq, void *dev_id __PT_REGS)
Signed-off-by: Bill Waddington <william.waddington@beezmo.com>
---
Has this suggestion by Ingo Molnar been implemented? May I
submit it? Is this how it's done?
--- 2.6.19-rc3/include/linux/interrupt.h.ORIG 2006-11-04
09:15:16.000000000 -0800
+++ 2.6.19-rc3/include/linux/interrupt.h 2006-11-04 09:23:18.000000000 -0800
@@ -66,6 +66,14 @@
typedef irqreturn_t (*irq_handler_t)(int, void *);
+/*
+ * Irq handler migration helper - empty 3rd argument
+ * #define __PT_REGS , struct pt_regs *regs
+ * for older kernel versions
+ */
+
+#define __PT_REGS
+
struct irqaction {
irq_handler_t handler;
unsigned long flags;
Bill
--
--------------------------------------------
William D Waddington
Bainbridge Island, WA, USA
william.waddington@beezmo.com
--------------------------------------------
"Even bugs...are unexpected signposts on
the long road of creativity..." - Ken Burtch
next reply other threads:[~2006-11-04 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 18:29 William D Waddington [this message]
2006-11-04 19:03 ` [PATCH] IRQ: ease out-of-tree migration to new irq_handler prototype Alexey Dobriyan
2006-11-04 20:06 ` William D Waddington
2006-11-05 2:04 ` Alexey Dobriyan
2006-11-05 14:56 ` William D Waddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454CDC11.5030708@beezmo.com \
--to=william.waddington@beezmo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox