From: Jeff Garzik <jgarzik@pobox.com>
To: Florin Malita <fmalita@gmail.com>
Cc: akpm@osdl.org, linville@tuxdriver.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] airo.c: check returned values
Date: Mon, 06 Nov 2006 02:57:31 -0500 [thread overview]
Message-ID: <454EEAEB.5030606@pobox.com> (raw)
In-Reply-To: <452C06A6.4030408@gmail.com>
Florin Malita wrote:
> create_proc_entry() can fail and return NULL in setup_proc_entry(), the
> result must be checked before dereferencing. (Coverity ID 1443)
>
> init_wifidev() & setup_proc_entry() can also fail in _init_airo_card().
>
> This adds the checks & cleanup code and removes some whitespace.
>
> Signed-off-by: Florin Malita <fmalita@gmail.com>
NAK: create_proc_entry() is complicated. You are correct it can fail
-- but to add to the confusion, when CONFIG_PROC_FS is disabled, the
wrapper will also return NULL -- which is NOT a failure case.
Jeff
next prev parent reply other threads:[~2006-11-06 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 20:46 [PATCH] airo.c: check returned values Florin Malita
2006-11-06 7:57 ` Jeff Garzik [this message]
2006-11-06 14:30 ` Florin Malita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454EEAEB.5030606@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=fmalita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox