* [patch -mm] s390: pagefault_disable/enable build fix
2006-11-02 7:54 2.6.19-rc4-mm2 Andrew Morton
@ 2006-11-02 9:05 ` Heiko Carstens
2006-11-02 9:11 ` Peter Zijlstra
2006-11-02 23:27 ` 2.6.19-rc4-mm2 [PATCH] acpi unsused variable cleanup Mariusz Kozlowski
` (4 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Heiko Carstens @ 2006-11-02 9:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Peter Zijlstra, Martin Schwidefsky
From: Heiko Carstens <heiko.carstens@de.ibm.com>
arch/s390/lib/lib.a(uaccess_std.o)(.text+0x282): In function `futex_atomic_op':
: undefined reference to `pagefault_disable'
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
Looks like we want to replace all asm/uaccess.h with linux/uaccess.h...
arch/s390/lib/uaccess_std.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.19-rc4-mm2/arch/s390/lib/uaccess_std.c
===================================================================
--- linux-2.6.19-rc4-mm2.orig/arch/s390/lib/uaccess_std.c 2006-11-02 09:37:08.000000000 +0100
+++ linux-2.6.19-rc4-mm2/arch/s390/lib/uaccess_std.c 2006-11-02 09:48:31.000000000 +0100
@@ -11,7 +11,7 @@
#include <linux/errno.h>
#include <linux/mm.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
#include <asm/futex.h>
#ifndef __s390x__
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: 2.6.19-rc4-mm2 [PATCH] acpi unsused variable cleanup
2006-11-02 7:54 2.6.19-rc4-mm2 Andrew Morton
2006-11-02 9:05 ` [patch -mm] s390: pagefault_disable/enable build fix Heiko Carstens
@ 2006-11-02 23:27 ` Mariusz Kozlowski
2006-11-03 15:08 ` 2.6.19-rc4-mm2 -- reiserfs umount panic Andy Whitcroft
` (3 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Mariusz Kozlowski @ 2006-11-02 23:27 UTC (permalink / raw)
To: Andrew Morton, linux-kernel
Hello,
So far 2.6.19-rc4-mm2 works fine for me. I attached trivial warning fix to
address this:
drivers/acpi/events/evmisc.c: In function 'acpi_ev_global_lock_handler':
drivers/acpi/events/evmisc.c:334: warning: unused variable 'status'
The patch is against 2.6.19-rc4-mm2.
Regards,
Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
---
--- linux-2.6.19-rc4-orig/drivers/acpi/events/evmisc.c 2006-11-02
23:51:15.000000000 +0100
+++ linux-2.6.19-rc4/drivers/acpi/events/evmisc.c 2006-11-03
00:02:40.000000000 +0100
@@ -331,7 +331,6 @@ static void ACPI_SYSTEM_XFACE acpi_ev_gl
static u32 acpi_ev_global_lock_handler(void *context)
{
u8 acquired = FALSE;
- acpi_status status;
/*
* Attempt to get the lock
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: 2.6.19-rc4-mm2 -- reiserfs umount panic
2006-11-02 7:54 2.6.19-rc4-mm2 Andrew Morton
2006-11-02 9:05 ` [patch -mm] s390: pagefault_disable/enable build fix Heiko Carstens
2006-11-02 23:27 ` 2.6.19-rc4-mm2 [PATCH] acpi unsused variable cleanup Mariusz Kozlowski
@ 2006-11-03 15:08 ` Andy Whitcroft
2006-11-03 19:02 ` Andrew Morton
2006-11-03 21:42 ` 2.6.19-rc4-mm2 Andrew James Wade
` (2 subsequent siblings)
5 siblings, 1 reply; 16+ messages in thread
From: Andy Whitcroft @ 2006-11-03 15:08 UTC (permalink / raw)
To: Andrew Morton, reiserfs-dev; +Cc: linux-kernel, reiserfs-list
Just happened to be watching a console of a test box when it was
performing a post job reboot and caught the following panic. This
specific machine is a ppc64. Sadly these are not part of the job.
/me considers how we could fix that. Perhaps we could just shove a
plain reboot at the end of one of the jobs ... hmmm.
-apw
REISERFS: panic (device sda3): journal_begin called without kernel lock held
kernel BUG in reiserfs_panic at fs/reiserfs/prints.c:361!
Oops: Exception in kernel mode, sig: 5 [#1]
SMP NR_CPUS=32 NUMA
Modules linked in:
NIP: C000000000125A60 LR: C000000000125A5C CTR: 00000000000D0274
REGS: c00000076e693640 TRAP: 0700 Not tainted (2.6.19-rc4-mm2-autokern1)
MSR: 8000000000029032 <EE,ME,IR,DR> CR: 22008424 XER: 00000000
TASK = c00000003fb68250[16416] 'umount' THREAD: c00000076e690000 CPU: 2
GPR00: C000000000125A5C C00000076E6938C0 C0000000006662E8 0000000000000050
GPR04: 0000000000000000 FFFFFFFFFFFFFFFF 656C206C6F636B20 68656C640D0A726E
GPR08: 0000000000000000 C00000000054EAB8 C00000000068F810 C00000000068F808
GPR12: 00000000000D0274 C000000000545500 0000000000000000 0000000000000000
GPR16: 00000000100A7D10 00000000100A94E0 0000000010070000 0000000000000000
GPR20: 0000000010010000 00000000FFFFFFFF 0000000010019218 0000000000000000
GPR24: 0000000000000000 000000000000000A C00000076E693BC0 000000000000000A
GPR28: C000000000518800 C00000076E693BC0 C000000000579080 C000000000518800
NIP [C000000000125A60] .reiserfs_panic+0x6c/0x90
LR [C000000000125A5C] .reiserfs_panic+0x68/0x90
Call Trace:
[C00000076E6938C0] [C000000000125A5C] .reiserfs_panic+0x68/0x90 (unreliable)
[C00000076E693940] [C000000000134A38] .reiserfs_check_lock_depth+0x30/0x48
[C00000076E6939C0] [C00000000013A654] .do_journal_begin_r+0x58/0x434
[C00000076E693AB0] [C00000000013AC54] .journal_begin+0x108/0x170
[C00000076E693B50] [C000000000123130] .reiserfs_remount+0x194/0x460
[C00000076E693C50] [C0000000000B47D0] .do_remount_sb+0x1a8/0x224
[C00000076E693CF0] [C0000000000D0E98] .sys_umount+0x19c/0x2a0
[C00000076E693E30] [C00000000000872C] syscall_exit+0x0/0x40
Instruction dump:
f90100d8 f92100e0 f94100e8 4bfff11d 4192000c 389f0218 48000008 e89e8178
e87e8180 e8be8080 4bf289b5 60000000 <0fe00000> 4192000c 389f0218 48000008
<3>Badness in do_exit at kernel/exit.c:853
Call Trace:
[C00000076E692E70] [C00000000000F198] .show_stack+0x74/0x1b4 (unreliable)
[C00000076E692F20] [C000000000021688] .program_check_exception+0x194/0x634
[C00000076E692FD0] [C000000000004774] program_check_common+0xf4/0x100
--- Exception: 700 at .do_exit+0x50/0xa1c
LR = .do_exit+0x44/0xa1c
[C00000076E693380] [C000000000021038] .die+0x150/0x154
[C00000076E693410] [C000000000021264] ._exception+0x48/0x138
[C00000076E693520] [C000000000021B0C] .program_check_exception+0x618/0x634
[C00000076E6935D0] [C000000000004774] program_check_common+0xf4/0x100
--- Exception: 700 at .reiserfs_panic+0x6c/0x90
LR = .reiserfs_panic+0x68/0x90
[C00000076E693940] [C000000000134A38] .reiserfs_check_lock_depth+0x30/0x48
[C00000076E6939C0] [C00000000013A654] .do_journal_begin_r+0x58/0x434
[C00000076E693AB0] [C00000000013AC54] .journal_begin+0x108/0x170
[C00000076E693B50] [C000000000123130] .reiserfs_remount+0x194/0x460
[C00000076E693C50] [C0000000000B47D0] .do_remount_sb+0x1a8/0x224
[C00000076E693CF0] [C0000000000D0E98] .sys_umount+0x19c/0x2a0
[C00000076E693E30] [C00000000000872C] syscall_exit+0x0/0x40
/etc/init.d/boot.d/K15boot.localfs: line 217: 16416 Trace/breakpoint
trap umount -avt noproc,nonfs,nosmbfs
failed
Oops: umount failed :-( -- trying to remount readonly...
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: 2.6.19-rc4-mm2 -- reiserfs umount panic
2006-11-03 15:08 ` 2.6.19-rc4-mm2 -- reiserfs umount panic Andy Whitcroft
@ 2006-11-03 19:02 ` Andrew Morton
2006-11-06 11:05 ` Vasily Averin
0 siblings, 1 reply; 16+ messages in thread
From: Andrew Morton @ 2006-11-03 19:02 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: reiserfs-dev, linux-kernel, reiserfs-list, Vasily Averin
On Fri, 03 Nov 2006 15:08:06 +0000
Andy Whitcroft <apw@shadowen.org> wrote:
> Just happened to be watching a console of a test box when it was
> performing a post job reboot and caught the following panic. This
> specific machine is a ppc64. Sadly these are not part of the job.
>
> /me considers how we could fix that. Perhaps we could just shove a
> plain reboot at the end of one of the jobs ... hmmm.
>
> -apw
>
> REISERFS: panic (device sda3): journal_begin called without kernel lock held
> kernel BUG in reiserfs_panic at fs/reiserfs/prints.c:361!
> Oops: Exception in kernel mode, sig: 5 [#1]
> SMP NR_CPUS=32 NUMA
> Modules linked in:
> NIP: C000000000125A60 LR: C000000000125A5C CTR: 00000000000D0274
> REGS: c00000076e693640 TRAP: 0700 Not tainted (2.6.19-rc4-mm2-autokern1)
> MSR: 8000000000029032 <EE,ME,IR,DR> CR: 22008424 XER: 00000000
> TASK = c00000003fb68250[16416] 'umount' THREAD: c00000076e690000 CPU: 2
> GPR00: C000000000125A5C C00000076E6938C0 C0000000006662E8 0000000000000050
> GPR04: 0000000000000000 FFFFFFFFFFFFFFFF 656C206C6F636B20 68656C640D0A726E
> GPR08: 0000000000000000 C00000000054EAB8 C00000000068F810 C00000000068F808
> GPR12: 00000000000D0274 C000000000545500 0000000000000000 0000000000000000
> GPR16: 00000000100A7D10 00000000100A94E0 0000000010070000 0000000000000000
> GPR20: 0000000010010000 00000000FFFFFFFF 0000000010019218 0000000000000000
> GPR24: 0000000000000000 000000000000000A C00000076E693BC0 000000000000000A
> GPR28: C000000000518800 C00000076E693BC0 C000000000579080 C000000000518800
> NIP [C000000000125A60] .reiserfs_panic+0x6c/0x90
> LR [C000000000125A5C] .reiserfs_panic+0x68/0x90
> Call Trace:
> [C00000076E6938C0] [C000000000125A5C] .reiserfs_panic+0x68/0x90 (unreliable)
> [C00000076E693940] [C000000000134A38] .reiserfs_check_lock_depth+0x30/0x48
> [C00000076E6939C0] [C00000000013A654] .do_journal_begin_r+0x58/0x434
> [C00000076E693AB0] [C00000000013AC54] .journal_begin+0x108/0x170
> [C00000076E693B50] [C000000000123130] .reiserfs_remount+0x194/0x460
> [C00000076E693C50] [C0000000000B47D0] .do_remount_sb+0x1a8/0x224
> [C00000076E693CF0] [C0000000000D0E98] .sys_umount+0x19c/0x2a0
> [C00000076E693E30] [C00000000000872C] syscall_exit+0x0/0x40
That thump you heard was the sound of
vfs-bkl-is-not-required-for-remount_fs.patch getting dropped. Thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: 2.6.19-rc4-mm2 -- reiserfs umount panic
2006-11-03 19:02 ` Andrew Morton
@ 2006-11-06 11:05 ` Vasily Averin
2006-11-06 11:08 ` [PATCH 2.6.19-rc4] Documentation: remount_fs() needs lock_kernel Vasily Averin
0 siblings, 1 reply; 16+ messages in thread
From: Vasily Averin @ 2006-11-06 11:05 UTC (permalink / raw)
To: Andrew Morton, Matthew Wilcox
Cc: Andy Whitcroft, reiserfs-dev, linux-kernel, reiserfs-list
Matthew,
4 years ago you have patched the Locking document and changed the BKL rule for
remount_fs()
# ChangeSet
# 2003/08/21 00:28:27-07:00 akpm@osdl.org
# [PATCH] update Documentation/filesystems/Locking
# From: Matthew Wilcox <willy@debian.org>
locking rules:
All may block.
- BKL s_lock mount_sem
-remount_fs: yes yes maybe (see below)
+ BKL s_lock s_umount
+remount_fs: no yes maybe (see below)
As far as I understand it was a misprint, de-facto BKL is required at least for
reiserfs, where is a long-lived check. Also I've found that currently
remount_fs() is called only from do_remount_sb(), which is called with taken BKL
in all cases:
- do_umount() and do_emergency_remount() acquires BKL directly;
- do_remount() which called from do_mount() with taken BKL;
- get_sb_single() which called from .get_sb() and should have BKL too
If you have not any objections I would like to fix this issue by the patch from
the following letter.
thank you,
Vasily Averin
Andrew Morton wrote:
> On Fri, 03 Nov 2006 15:08:06 +0000
> Andy Whitcroft <apw@shadowen.org> wrote:
>
>> Just happened to be watching a console of a test box when it was
>> performing a post job reboot and caught the following panic. This
>> specific machine is a ppc64. Sadly these are not part of the job.
>>
>> /me considers how we could fix that. Perhaps we could just shove a
>> plain reboot at the end of one of the jobs ... hmmm.
>>
>> -apw
>>
>> REISERFS: panic (device sda3): journal_begin called without kernel lock held
>> kernel BUG in reiserfs_panic at fs/reiserfs/prints.c:361!
>> Oops: Exception in kernel mode, sig: 5 [#1]
>> SMP NR_CPUS=32 NUMA
>> Modules linked in:
>> NIP: C000000000125A60 LR: C000000000125A5C CTR: 00000000000D0274
>> REGS: c00000076e693640 TRAP: 0700 Not tainted (2.6.19-rc4-mm2-autokern1)
>> MSR: 8000000000029032 <EE,ME,IR,DR> CR: 22008424 XER: 00000000
>> TASK = c00000003fb68250[16416] 'umount' THREAD: c00000076e690000 CPU: 2
>> GPR00: C000000000125A5C C00000076E6938C0 C0000000006662E8 0000000000000050
>> GPR04: 0000000000000000 FFFFFFFFFFFFFFFF 656C206C6F636B20 68656C640D0A726E
>> GPR08: 0000000000000000 C00000000054EAB8 C00000000068F810 C00000000068F808
>> GPR12: 00000000000D0274 C000000000545500 0000000000000000 0000000000000000
>> GPR16: 00000000100A7D10 00000000100A94E0 0000000010070000 0000000000000000
>> GPR20: 0000000010010000 00000000FFFFFFFF 0000000010019218 0000000000000000
>> GPR24: 0000000000000000 000000000000000A C00000076E693BC0 000000000000000A
>> GPR28: C000000000518800 C00000076E693BC0 C000000000579080 C000000000518800
>> NIP [C000000000125A60] .reiserfs_panic+0x6c/0x90
>> LR [C000000000125A5C] .reiserfs_panic+0x68/0x90
>> Call Trace:
>> [C00000076E6938C0] [C000000000125A5C] .reiserfs_panic+0x68/0x90 (unreliable)
>> [C00000076E693940] [C000000000134A38] .reiserfs_check_lock_depth+0x30/0x48
>> [C00000076E6939C0] [C00000000013A654] .do_journal_begin_r+0x58/0x434
>> [C00000076E693AB0] [C00000000013AC54] .journal_begin+0x108/0x170
>> [C00000076E693B50] [C000000000123130] .reiserfs_remount+0x194/0x460
>> [C00000076E693C50] [C0000000000B47D0] .do_remount_sb+0x1a8/0x224
>> [C00000076E693CF0] [C0000000000D0E98] .sys_umount+0x19c/0x2a0
>> [C00000076E693E30] [C00000000000872C] syscall_exit+0x0/0x40
>
> That thump you heard was the sound of
> vfs-bkl-is-not-required-for-remount_fs.patch getting dropped. Thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2.6.19-rc4] Documentation: remount_fs() needs lock_kernel
2006-11-06 11:05 ` Vasily Averin
@ 2006-11-06 11:08 ` Vasily Averin
0 siblings, 0 replies; 16+ messages in thread
From: Vasily Averin @ 2006-11-06 11:08 UTC (permalink / raw)
To: Andrew Morton, Matthew Wilcox
Cc: Andy Whitcroft, reiserfs-dev, linux-kernel, reiserfs-list
From: Vasily Averin <vvs@sw.ru>
fixed long-lived typo: remount_fs() needs BKL
Signed-off-by: Vasily Averin <vvs@sw.ru>
--- linux-2.6.19-rc4/Documentation/filesystems/Locking.umntlk 2006-11-02
13:25:04.000000000 +0300
+++ linux-2.6.19-rc4/Documentation/filesystems/Locking 2006-11-06
13:22:35.000000000 +0300
@@ -124,7 +124,7 @@ sync_fs: no no read
write_super_lockfs: ?
unlockfs: ?
statfs: no no no
-remount_fs: no yes maybe (see below)
+remount_fs: yes yes maybe (see below)
clear_inode: no
umount_begin: yes no no
show_options: no (vfsmount->sem)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: 2.6.19-rc4-mm2
2006-11-02 7:54 2.6.19-rc4-mm2 Andrew Morton
` (2 preceding siblings ...)
2006-11-03 15:08 ` 2.6.19-rc4-mm2 -- reiserfs umount panic Andy Whitcroft
@ 2006-11-03 21:42 ` Andrew James Wade
2006-11-03 21:51 ` 2.6.19-rc4-mm2 Andrew Morton
2006-11-04 20:20 ` 2.6.19-rc4-mm2 Mariusz Kozlowski
2006-11-06 18:35 ` [PATCH] s390 need definitions for pagefault_disable and pagefault_enable Andy Whitcroft
5 siblings, 1 reply; 16+ messages in thread
From: Andrew James Wade @ 2006-11-03 21:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Thursday 02 November 2006 02:54, Andrew Morton wrote:
> - Lots of fbdev updates. We haven't heard from Tony in several months, so I
> went on a linux-fbdev-devel fishing expedition.
radeonfb-support-24bpp-32bpp-minus-alpha.patch broke my video: my
screen ended up garbled. (vc1 was ok, strangely enough). Reverting
fixed things.
lspci -v:
0000:01:00.0 VGA compatible controller: ATI Technologies Inc Radeon RV200 QW [Radeon 7500] (prog-if 00 [VGA])
Subsystem: ATI Technologies Inc Radeon 7500
Flags: bus master, stepping, 66MHz, medium devsel, latency 64, IRQ 16
Memory at d8000000 (32-bit, prefetchable) [size=128M]
I/O ports at d800 [size=256]
Memory at d7000000 (32-bit, non-prefetchable) [size=64K]
Expansion ROM at d7fe0000 [disabled] [size=128K]
Capabilities: <available only to root>
-ajw
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: 2.6.19-rc4-mm2
2006-11-03 21:42 ` 2.6.19-rc4-mm2 Andrew James Wade
@ 2006-11-03 21:51 ` Andrew Morton
0 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2006-11-03 21:51 UTC (permalink / raw)
To: andrew.j.wade
Cc: linux-kernel, Charlotte Richardson, Kimball Murray,
linux-fbdev-devel
On Fri, 3 Nov 2006 16:42:33 -0500
Andrew James Wade <andrew.j.wade@gmail.com> wrote:
> On Thursday 02 November 2006 02:54, Andrew Morton wrote:
> > - Lots of fbdev updates. We haven't heard from Tony in several months, so I
> > went on a linux-fbdev-devel fishing expedition.
>
> radeonfb-support-24bpp-32bpp-minus-alpha.patch broke my video: my
> screen ended up garbled. (vc1 was ok, strangely enough). Reverting
> fixed things.
>
> lspci -v:
>
> 0000:01:00.0 VGA compatible controller: ATI Technologies Inc Radeon RV200 QW [Radeon 7500] (prog-if 00 [VGA])
> Subsystem: ATI Technologies Inc Radeon 7500
> Flags: bus master, stepping, 66MHz, medium devsel, latency 64, IRQ 16
> Memory at d8000000 (32-bit, prefetchable) [size=128M]
> I/O ports at d800 [size=256]
> Memory at d7000000 (32-bit, non-prefetchable) [size=64K]
> Expansion ROM at d7fe0000 [disabled] [size=128K]
> Capabilities: <available only to root>
>
Great, thanks for working that out. I'll drop the patch.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: 2.6.19-rc4-mm2
2006-11-02 7:54 2.6.19-rc4-mm2 Andrew Morton
` (3 preceding siblings ...)
2006-11-03 21:42 ` 2.6.19-rc4-mm2 Andrew James Wade
@ 2006-11-04 20:20 ` Mariusz Kozlowski
2006-11-06 18:35 ` [PATCH] s390 need definitions for pagefault_disable and pagefault_enable Andy Whitcroft
5 siblings, 0 replies; 16+ messages in thread
From: Mariusz Kozlowski @ 2006-11-04 20:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Hello,
After allyesconfig I found this on one of my box'es. Not sure how to fix
that. Don't want to mess with headers ;-)
CC drivers/media/video/pwc/pwc-uncompress.o
In file included from drivers/media/video/pwc/pwc-uncompress.c:29:
include/asm/current.h: In function `get_current':
include/asm/current.h:11: error: `size_t' undeclared (first use in this
function)
include/asm/current.h:11: error: (Each undeclared identifier is reported only
once
include/asm/current.h:11: error: for each function it appears in.)
make[4]: *** [drivers/media/video/pwc/pwc-uncompress.o] Error 1
make[3]: *** [drivers/media/video/pwc] Error 2
make[2]: *** [drivers/media/video] Error 2
make[1]: *** [drivers/media] Error 2
make: *** [drivers] Error 2
Regards,
Mariusz Kozlowski
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH] s390 need definitions for pagefault_disable and pagefault_enable
2006-11-02 7:54 2.6.19-rc4-mm2 Andrew Morton
` (4 preceding siblings ...)
2006-11-04 20:20 ` 2.6.19-rc4-mm2 Mariusz Kozlowski
@ 2006-11-06 18:35 ` Andy Whitcroft
2006-11-07 8:13 ` Heiko Carstens
5 siblings, 1 reply; 16+ messages in thread
From: Andy Whitcroft @ 2006-11-06 18:35 UTC (permalink / raw)
To: schwidefsky, heiko.carstens, linux390
Cc: Andrew Morton, Linux Kernel Mailing List, Andy Whitcroft,
linux-390
s390: need definitions for pagefault_disable and pagefault_enable
Seems that when the changes for user futex's went into 2.6.19-rc4-mm2
s390 was missed. Leading to the following compile failure:
arch/s390/lib/lib.a(uaccess_std.o)(.text+0x37c): In function
`futex_atomic_op':
: undefined reference to `pagefault_disable'
arch/s390/lib/lib.a(uaccess_std.o)(.text+0x3cc): In function
`futex_atomic_op':
: undefined reference to `pagefault_enable'
[...]
This seems to be enough to get testing working again.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
diff --git a/arch/s390/lib/uaccess_std.c b/arch/s390/lib/uaccess_std.c
index 9bbeaa0..ad296dc 100644
--- a/arch/s390/lib/uaccess_std.c
+++ b/arch/s390/lib/uaccess_std.c
@@ -11,6 +11,8 @@
#include <linux/errno.h>
#include <linux/mm.h>
+#include <linux/uaccess.h>
+
#include <asm/uaccess.h>
#include <asm/futex.h>
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH] s390 need definitions for pagefault_disable and pagefault_enable
2006-11-06 18:35 ` [PATCH] s390 need definitions for pagefault_disable and pagefault_enable Andy Whitcroft
@ 2006-11-07 8:13 ` Heiko Carstens
2006-11-07 10:09 ` Andy Whitcroft
0 siblings, 1 reply; 16+ messages in thread
From: Heiko Carstens @ 2006-11-07 8:13 UTC (permalink / raw)
To: Andy Whitcroft
Cc: schwidefsky, linux390, Andrew Morton, Linux Kernel Mailing List,
linux-390
On Mon, Nov 06, 2006 at 06:35:21PM +0000, Andy Whitcroft wrote:
> diff --git a/arch/s390/lib/uaccess_std.c b/arch/s390/lib/uaccess_std.c
> index 9bbeaa0..ad296dc 100644
> --- a/arch/s390/lib/uaccess_std.c
> +++ b/arch/s390/lib/uaccess_std.c
> @@ -11,6 +11,8 @@
>
> #include <linux/errno.h>
> #include <linux/mm.h>
> +#include <linux/uaccess.h>
> +
> #include <asm/uaccess.h>
> #include <asm/futex.h>
http://lkml.org/lkml/2006/11/2/54
;)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] s390 need definitions for pagefault_disable and pagefault_enable
2006-11-07 8:13 ` Heiko Carstens
@ 2006-11-07 10:09 ` Andy Whitcroft
2006-11-07 10:13 ` Heiko Carstens
0 siblings, 1 reply; 16+ messages in thread
From: Andy Whitcroft @ 2006-11-07 10:09 UTC (permalink / raw)
To: Heiko Carstens
Cc: schwidefsky, linux390, Andrew Morton, Linux Kernel Mailing List,
linux-390
Heiko Carstens wrote:
> On Mon, Nov 06, 2006 at 06:35:21PM +0000, Andy Whitcroft wrote:
>> diff --git a/arch/s390/lib/uaccess_std.c b/arch/s390/lib/uaccess_std.c
>> index 9bbeaa0..ad296dc 100644
>> --- a/arch/s390/lib/uaccess_std.c
>> +++ b/arch/s390/lib/uaccess_std.c
>> @@ -11,6 +11,8 @@
>>
>> #include <linux/errno.h>
>> #include <linux/mm.h>
>> +#include <linux/uaccess.h>
>> +
>> #include <asm/uaccess.h>
>> #include <asm/futex.h>
>
> http://lkml.org/lkml/2006/11/2/54
>
> ;)
Perhaps it would be helpful if these went out as replies to akpm's -mm
announcement else you have to sift the whole of lkml for them :(.
-apw
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] s390 need definitions for pagefault_disable and pagefault_enable
2006-11-07 10:09 ` Andy Whitcroft
@ 2006-11-07 10:13 ` Heiko Carstens
2006-11-07 10:36 ` Andy Whitcroft
0 siblings, 1 reply; 16+ messages in thread
From: Heiko Carstens @ 2006-11-07 10:13 UTC (permalink / raw)
To: Andy Whitcroft
Cc: schwidefsky, linux390, Andrew Morton, Linux Kernel Mailing List,
linux-390
On Tue, Nov 07, 2006 at 10:09:44AM +0000, Andy Whitcroft wrote:
> Heiko Carstens wrote:
> > On Mon, Nov 06, 2006 at 06:35:21PM +0000, Andy Whitcroft wrote:
> >> diff --git a/arch/s390/lib/uaccess_std.c b/arch/s390/lib/uaccess_std.c
> >> index 9bbeaa0..ad296dc 100644
> >> --- a/arch/s390/lib/uaccess_std.c
> >> +++ b/arch/s390/lib/uaccess_std.c
> >> @@ -11,6 +11,8 @@
> >>
> >> #include <linux/errno.h>
> >> #include <linux/mm.h>
> >> +#include <linux/uaccess.h>
> >> +
> >> #include <asm/uaccess.h>
> >> #include <asm/futex.h>
> >
> > http://lkml.org/lkml/2006/11/2/54
> >
> > ;)
>
> Perhaps it would be helpful if these went out as replies to akpm's -mm
> announcement else you have to sift the whole of lkml for them :(.
??? It was the first reply to the -mm accouncement and that's where you
can find it in the tree: http://lkml.org/lkml/2006/11/2/33
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] s390 need definitions for pagefault_disable and pagefault_enable
2006-11-07 10:13 ` Heiko Carstens
@ 2006-11-07 10:36 ` Andy Whitcroft
0 siblings, 0 replies; 16+ messages in thread
From: Andy Whitcroft @ 2006-11-07 10:36 UTC (permalink / raw)
To: Heiko Carstens
Cc: schwidefsky, linux390, Andrew Morton, Linux Kernel Mailing List,
linux-390
Heiko Carstens wrote:
> On Tue, Nov 07, 2006 at 10:09:44AM +0000, Andy Whitcroft wrote:
>> Heiko Carstens wrote:
>>> On Mon, Nov 06, 2006 at 06:35:21PM +0000, Andy Whitcroft wrote:
>>>> diff --git a/arch/s390/lib/uaccess_std.c b/arch/s390/lib/uaccess_std.c
>>>> index 9bbeaa0..ad296dc 100644
>>>> --- a/arch/s390/lib/uaccess_std.c
>>>> +++ b/arch/s390/lib/uaccess_std.c
>>>> @@ -11,6 +11,8 @@
>>>>
>>>> #include <linux/errno.h>
>>>> #include <linux/mm.h>
>>>> +#include <linux/uaccess.h>
>>>> +
>>>> #include <asm/uaccess.h>
>>>> #include <asm/futex.h>
>>> http://lkml.org/lkml/2006/11/2/54
>>>
>>> ;)
>> Perhaps it would be helpful if these went out as replies to akpm's -mm
>> announcement else you have to sift the whole of lkml for them :(.
>
> ??? It was the first reply to the -mm accouncement and that's where you
> can find it in the tree: http://lkml.org/lkml/2006/11/2/33
Applogies, I have no idea what kind of user incompetance led me twice to
look and miss it. But for sure its there.
-apw
^ permalink raw reply [flat|nested] 16+ messages in thread