public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: 2.6.18-rt7: rollover with 32-bit cycles_t
Date: Tue, 07 Nov 2006 17:36:11 -0800	[thread overview]
Message-ID: <4551348B.6070604@mvista.com> (raw)

On ARM, I'm noticing the 'bug' message from check_critical_timing()
where two calls to get_cycles() are compared and the 2nd is assumed to
be >= the first.

This isn't properly handling the case of rollover which occurs
relatively often with fast hardware clocks and 32-bit cycle counters.

Is this really a bug?  If the get_cycles() can be assumed to run between
0 and (cycles_t)~0, using the right unsigned math could get a proper
delta even in the rollover case.  Is this a safe assumption?

Kevin






             reply	other threads:[~2006-11-08  1:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08  1:36 Kevin Hilman [this message]
2006-11-08  2:06 ` 2.6.18-rt7: rollover with 32-bit cycles_t john cooper
2006-11-08 19:22   ` Kevin Hilman
2006-11-09  9:14     ` Ingo Molnar
2006-11-08  3:23 ` Daniel Walker
2006-11-08 13:29   ` john cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4551348B.6070604@mvista.com \
    --to=khilman@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox