[PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

[PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

[Alexey Dobriyan]

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 drivers/char/ipmi/ipmi_si_intf.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1211,7 +1211,7 @@ static void intf_mem_outb(struct si_sm_i
 static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
 {
 	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
-		&& 0xff;
+		& 0xff;
 }
 
 static void intf_mem_outw(struct si_sm_io *io, unsigned int offset,
@@ -1223,7 +1223,7 @@ static void intf_mem_outw(struct si_sm_i
 static unsigned char intf_mem_inl(struct si_sm_io *io, unsigned int offset)
 {
 	return (readl((io->addr)+(offset * io->regspacing)) >> io->regshift)
-		&& 0xff;
+		& 0xff;
 }
 
 static void intf_mem_outl(struct si_sm_io *io, unsigned int offset,
@@ -1236,7 +1236,7 @@ #ifdef readq
 static unsigned char mem_inq(struct si_sm_io *io, unsigned int offset)
 {
 	return (readq((io->addr)+(offset * io->regspacing)) >> io->regshift)
-		&& 0xff;
+		& 0xff;
 }
 
 static void mem_outq(struct si_sm_io *io, unsigned int offset,

Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

[Corey Minyard]

Ouch, I guess we've never had a system with these address types.  Thanks.

-Corey

Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
>  drivers/char/ipmi/ipmi_si_intf.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1211,7 +1211,7 @@ static void intf_mem_outb(struct si_sm_i
>  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void intf_mem_outw(struct si_sm_io *io, unsigned int offset,
> @@ -1223,7 +1223,7 @@ static void intf_mem_outw(struct si_sm_i
>  static unsigned char intf_mem_inl(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readl((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void intf_mem_outl(struct si_sm_io *io, unsigned int offset,
> @@ -1236,7 +1236,7 @@ #ifdef readq
>  static unsigned char mem_inq(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readq((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void mem_outq(struct si_sm_io *io, unsigned int offset,
>   

Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
> Ouch, I guess we've never had a system with these address types.  Thanks.

If we never had a system with these address types..

> >  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
> >  {
> >  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
> > -		&& 0xff;
> > +		& 0xff;
> >  }

Is this dead code that isn't called by anybody?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

[Corey Minyard]

Valdis.Kletnieks@vt.edu wrote:
> On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
>   
>> Ouch, I guess we've never had a system with these address types.  Thanks.
>>     
>
> If we never had a system with these address types..
>
>   
>>>  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>>>  {
>>>  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
>>> -		&& 0xff;
>>> +		& 0xff;
>>>  }
>>>       
>
> Is this dead code that isn't called by anybody?
>   
Well, not exactly.  The SMBIOS or ACPI tables that report these interfaces
have various options for the size of the device registers.  The driver
implements all the options, but there may or may not be systems with
every option available.  But I can't exactly guess what is available in the
field.

-Corey