From: Corey Minyard <minyard@acm.org>
To: Valdis.Kletnieks@vt.edu
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos
Date: Thu, 09 Nov 2006 08:45:28 -0600 [thread overview]
Message-ID: <45533F08.3040508@acm.org> (raw)
In-Reply-To: <200611090449.kA94nqsZ007282@turing-police.cc.vt.edu>
Valdis.Kletnieks@vt.edu wrote:
> On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
>
>> Ouch, I guess we've never had a system with these address types. Thanks.
>>
>
> If we never had a system with these address types..
>
>
>>> static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>>> {
>>> return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
>>> - && 0xff;
>>> + & 0xff;
>>> }
>>>
>
> Is this dead code that isn't called by anybody?
>
Well, not exactly. The SMBIOS or ACPI tables that report these interfaces
have various options for the size of the device registers. The driver
implements all the options, but there may or may not be systems with
every option available. But I can't exactly guess what is available in the
field.
-Corey
prev parent reply other threads:[~2006-11-09 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 22:09 [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos Alexey Dobriyan
2006-11-08 22:15 ` Corey Minyard
2006-11-09 4:49 ` Valdis.Kletnieks
2006-11-09 14:45 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45533F08.3040508@acm.org \
--to=minyard@acm.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox