From: Michael Krufky <mkrufky@linuxtv.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org,
Patrick Boettcher <pb@linuxtv.org>
Subject: Re: [v4l-dvb-maintainer] [PATCH] flexcop-usb.c: fix "&& 0xff" typos and ...
Date: Thu, 09 Nov 2006 11:40:54 -0500 [thread overview]
Message-ID: <45535A16.9060706@linuxtv.org> (raw)
In-Reply-To: <20061108222527.GF4972@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> .. fix debug printk. Why, oh why, one would want to do
>
> (u16 & 0xff) << 8
>
> and print it with %02x format?
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
I spoke to Patrick in irc and confirmed the fix...
Acked-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
> ---
>
> drivers/media/dvb/b2c2/flexcop-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/dvb/b2c2/flexcop-usb.c
> +++ b/drivers/media/dvb/b2c2/flexcop-usb.c
> @@ -246,7 +246,7 @@ static int flexcop_usb_i2c_req(struct fl
> wIndex = (chipaddr << 8 ) | addr;
>
> deb_i2c("i2c %2d: %02x %02x %02x %02x %02x %02x\n",func,request_type,req,
> - ((wValue && 0xff) << 8),wValue >> 8,((wIndex && 0xff) << 8),wIndex >> 8);
> + wValue & 0xff, wValue >> 8, wIndex & 0xff, wIndex >> 8);
>
> len = usb_control_msg(fc_usb->udev,pipe,
> req,
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
--
Michael Krufky
prev parent reply other threads:[~2006-11-09 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 22:25 [PATCH] flexcop-usb.c: fix "&& 0xff" typos and Alexey Dobriyan
2006-11-09 16:40 ` Michael Krufky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45535A16.9060706@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pb@linuxtv.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox