public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: chengzhihao1@huawei.com
Cc: david oberhollenzer <david.oberhollenzer@sigma-star.at>,
	david <david@sigma-star.at>,
	boris brezillon <boris.brezillon@free-electrons.com>,
	yi zhang <yi.zhang@huawei.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] mtd: ubi: Add fastmap sysfs attribute
Date: Fri, 28 Jun 2019 08:48:28 +0200 (CEST)	[thread overview]
Message-ID: <455367016.19242.1561704508169.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1561698143-5027-1-git-send-email-chengzhihao1@huawei.com>

Zhihao Cheng,

----- Ursprüngliche Mail -----
> +	else if (attr == &dev_fastmap)
> +		ret = sprintf(buf, "%d\n", ubi->fm ? 1 : 0);
> 	else

I fear this is not correct. ubi->fm is an internal data structure
of UBI.
UBI sets it to NULL while it updates fastmap, and updates it later.
So userspace would see false negatives.

Thanks,
//richard

  reply	other threads:[~2019-06-28  6:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  5:02 [PATCH RFC] mtd: ubi: Add fastmap sysfs attribute Zhihao, Cheng
2019-06-28  6:48 ` Richard Weinberger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-06-28  6:35 Zhihao Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455367016.19242.1561704508169.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=boris.brezillon@free-electrons.com \
    --cc=chengzhihao1@huawei.com \
    --cc=david.oberhollenzer@sigma-star.at \
    --cc=david@sigma-star.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox