public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
	linux-kernel@vger.kernel.org, linux-aio@kvack.org,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [RFC][PATCH] Fix lock inversion aio_kick_handler()
Date: Thu, 09 Nov 2006 14:51:59 -0800	[thread overview]
Message-ID: <4553B10F.1020505@oracle.com> (raw)
In-Reply-To: <x49velokztg.fsf@segfault.boston.devel.redhat.com>


> Zach> > Doh.  Unfortunately, this patch isn't entirely correct as it
> Zach> could race with > __put_ioctx() which sets ioctx->mm = NULL.
> 
> Zach> Aha, yeah, that's what I was missing.  Thanks.
> 
> Zach> > Something like the following should do the trick:
> 
> Zach> Cool, I'll respin and send it out.
> 
> Did you ever resend this patch, Zach?

Sadly, no.  I vaguely remember thinking that the refcounting was pretty
messed up in these paths and that more than just this patch was needed.
 I don't remember the details.

Maybe I should take a look again :/.

> current kernels.  I'm still running into the lockdep warnings.

When doing what?  Working with that IO_CMD_EPOLL_WAIT patch?

- z

  reply	other threads:[~2006-11-09 22:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29  0:10 [RFC][PATCH] Fix lock inversion aio_kick_handler() Zach Brown
2006-07-29  1:34 ` Benjamin LaHaise
2006-07-29  2:02   ` Zach Brown
2006-11-09 22:41     ` Jeff Moyer
2006-11-09 22:51       ` Zach Brown [this message]
2006-11-09 22:57         ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4553B10F.1020505@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=arjan@infradead.org \
    --cc=bcrl@kvack.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox