public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: "Sébastien Dugué" <sebastien.dugue@bull.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Ulrich Drepper <drepper@redhat.com>,
	Zach Brown <zach.brown@oracle.com>, Dave Jones <davej@redhat.com>,
	Jean Pierre Dion <jean-pierre.dion@bull.net>,
	"linux-aio@kvack.org" <linux-aio@kvack.org>
Subject: Re: [PATCH -mm 3/3][AIO] - AIO completion signal notification
Date: Thu, 09 Nov 2006 17:52:28 -0800	[thread overview]
Message-ID: <4553DB5C.8030405@us.ibm.com> (raw)
In-Reply-To: <1163087946.3879.43.camel@frecb000686>

Sébastien Dugué wrote:
>                       AIO completion signal notification
>
>  
> +
> +	/* Release task ref */
> +	if (req->ki_notify.notify == (SIGEV_SIGNAL|SIGEV_THREAD_ID))
> +		put_task_struct(req->ki_notify.target);
> +
Huh ?? I thought user can set SIGEV_SIGNAL or SIGEV_THREAD_ID.
Not both. Isn't it ? Shouldn't this be ?

    if ((req->ki_notify.notify == SIGEV_SIGNAL) || 
(req->ki_notify.notify == SIGEV_THREAD_ID))
       ...

Samething in get_task_struct() also..

Thanks,
Badari


  parent reply	other threads:[~2006-11-10  1:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-09 15:55 [PATCH -mm 0/3][AIO] - AIO completion signal notification Sébastien Dugué
2006-11-09 15:58 ` [PATCH -mm 1/3][AIO] " Sébastien Dugué
2006-11-09 15:59 ` [PATCH -mm 2/3][AIO] " Sébastien Dugué
2006-11-09 15:59 ` [PATCH -mm 3/3][AIO] " Sébastien Dugué
2006-11-09 18:46   ` Badari Pulavarty
2006-11-10  9:05     ` Sébastien Dugué
2006-11-09 19:08   ` Christoph Hellwig
2006-11-09 19:27     ` Badari Pulavarty
2006-11-10  9:20       ` Sébastien Dugué
2006-11-10  9:14     ` Sébastien Dugué
2006-11-09 19:18   ` Badari Pulavarty
2006-11-10  9:22     ` Sébastien Dugué
2006-11-10  1:52   ` Badari Pulavarty [this message]
2006-11-10  1:54     ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4553DB5C.8030405@us.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=davej@redhat.com \
    --cc=drepper@redhat.com \
    --cc=jean-pierre.dion@bull.net \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastien.dugue@bull.net \
    --cc=suparna@in.ibm.com \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox