Typo in drivers/usb/input/wacom_wac.c?

Typo in drivers/usb/input/wacom_wac.c?

[Andrew Benton]

Hello World,
my Wacom Volito2 tablet doesn't work with the kernel driver as it is. 
The cursor jitters about at the bottom of the screen in a useless 
manner. However, if I edit drivers/usb/input/wacom_wac.c and change the 
two instances of wacom_be16_to_cpu to wacom_le16_to_cpu then it works 
perfectly

sed -i 's/_b/_l/' drivers/usb/input/wacom_wac.c

Andy

Re: Typo in drivers/usb/input/wacom_wac.c?

[Greg KH]

On Wed, Nov 08, 2006 at 09:55:13AM +0000, Andrew Benton wrote:
> Hello World,
> my Wacom Volito2 tablet doesn't work with the kernel driver as it is. 
> The cursor jitters about at the bottom of the screen in a useless 
> manner. However, if I edit drivers/usb/input/wacom_wac.c and change the 
> two instances of wacom_be16_to_cpu to wacom_le16_to_cpu then it works 
> perfectly
> 
> sed -i 's/_b/_l/' drivers/usb/input/wacom_wac.c

Which kernel version are you referring to?

Ping, any thoughts?

thanks,

greg k-h

RE: Typo in drivers/usb/input/wacom_wac.c?

[Ping Cheng]

The two wacom_be16_to_cpu are in wacom_intuos_irq, which has nothing to do with Volito2. Volito2 uses wacom_graphire_irq. I am not exactly sure what Andrew's problem is. 

Andrew, please surf the discussion forum at http://linuxwacom.sourceforge.net/ to see if there is anything similiar to your problem.

Ping

-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Wednesday, November 08, 2006 7:19 AM
To: Andrew Benton; Ping Cheng
Cc: Linux Kernel Mailing List
Subject: Re: Typo in drivers/usb/input/wacom_wac.c?


On Wed, Nov 08, 2006 at 09:55:13AM +0000, Andrew Benton wrote:
> Hello World,
> my Wacom Volito2 tablet doesn't work with the kernel driver as it is. 
> The cursor jitters about at the bottom of the screen in a useless 
> manner. However, if I edit drivers/usb/input/wacom_wac.c and change the 
> two instances of wacom_be16_to_cpu to wacom_le16_to_cpu then it works 
> perfectly
> 
> sed -i 's/_b/_l/' drivers/usb/input/wacom_wac.c

Which kernel version are you referring to?

Ping, any thoughts?

thanks,

greg k-h

Re: Typo in drivers/usb/input/wacom_wac.c?

[Andrew Benton]

Greg KH wrote:
> On Wed, Nov 08, 2006 at 09:55:13AM +0000, Andrew Benton wrote:
>> Hello World,
>> my Wacom Volito2 tablet doesn't work with the kernel driver as it is. 
>> The cursor jitters about at the bottom of the screen in a useless 
>> manner. However, if I edit drivers/usb/input/wacom_wac.c and change the 
>> two instances of wacom_be16_to_cpu to wacom_le16_to_cpu then it works 
>> perfectly
>>
>> sed -i 's/_b/_l/' drivers/usb/input/wacom_wac.c
> 
> Which kernel version are you referring to?

2.6.19-rc5

Andy

Re: Typo in drivers/usb/input/wacom_wac.c?

[Andrew Benton]

Ping Cheng wrote:
> The two wacom_be16_to_cpu are in wacom_intuos_irq, which has nothing to do with Volito2. Volito2 uses wacom_graphire_irq. I am not exactly sure what Andrew's problem is. 

The problem is that the wacom kernel driver in the 2.6.19-rc5 kernel 
doesn't work with my Volito 2 tablet. The cursor stays in the bottom 
right hand corner of the screen and only responds to me moving the pen 
by jittering about a bit.
 From what you said it seems that the kernel wacom driver treats my 
volito2 as though it's an intuos. The kernel correctly identifies it as 
a volito 2 in the system log but if I don't apply that sed to the source 
before I compile the kernel the tablet doesn't work.

Andy

Re: Typo in drivers/usb/input/wacom_wac.c?

[Andrew Benton]

Ping Cheng wrote:
> Yes, I understand your Volito2 doesn't work. I guess I should phase my sentence as:
> 
> I am not exactly sure what THE ROOT CAUSE of your problem is.  Volito and Volito2 have had issues with the statement 
> 
> if (data[0] == 99) return; 
> 
> in wacom_graphire_irq for a while. Some users said they have to have that line.  But more users said that line should not be there. 
> 
> The current version of wacom_wac.c doesn't have it (it was there in previous versions).
> 
> Andy, let's talk about it offline to figure out your problem.  
> 
> Ping
> 
> -----Original Message-----
> From: Andrew Benton [mailto:b3nt@supanet.com]
> Sent: Thursday, November 09, 2006 1:21 PM
> To: Ping Cheng
> Cc: Greg KH; Linux Kernel Mailing List
> Subject: Re: Typo in drivers/usb/input/wacom_wac.c?
> 
> 
> Ping Cheng wrote:
>> The two wacom_be16_to_cpu are in wacom_intuos_irq, which has nothing to do with Volito2. Volito2 uses wacom_graphire_irq. I am not exactly sure what Andrew's problem is. 

User error. This entire thread was based on a mistake. Sorry for wasting 
your time.

Andy