From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbcD0UBJ (ORCPT ); Wed, 27 Apr 2016 16:01:09 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:49576 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237AbcD0UBH (ORCPT ); Wed, 27 Apr 2016 16:01:07 -0400 From: Arnd Bergmann To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Alexandre Belloni , Stephen Boyd , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] char/rtc: replace blacklist with whitelist Date: Wed, 27 Apr 2016 22:00:51 +0200 Message-ID: <4558690.yfgPAfpkgV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1461786317-568103-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:gDO67Gz1X/Z/XAo1A+OnhKB/jqUEG8301IWUb2oPC3iXV1xJUHA /W+tcI240xCXgOi/K/z9w1tdqRGy3fNunilUQODKPaQ16HpxY2wpU6+xUxLfq2pCZ1ef3z2 oUVlsFWU6fUA9KXRMBIL/BwY7bj5VoNVuCbaU3ST7FIZNqOx1NET4XOTz0tAh1nSgR94iEA EFH80AtY2hVNsiBOScqLQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Wj3FjNyElkM=:1BNZVUmxQiBdwNuEhqVa8N 1xsg1raa1n+BEmMj3pgtfh/WBBT5w/hF427m0ZkGeafuBXHnCyjF6JIVPIW/DoPDXzvsG3QEW VdYvRrUu+xXIc/mmcJGfAKVRj5rHEKNtjr6INNnnk+KoTOdvs/KhMhOhHj+PgosqtAAuf2GWY 7C+68bbnzorzNczIW7lG4t72zZpoNlne0EpDXkDLf5ETbGFezWGZRIswi+owLnbHuYEcv0fyz Fg7ikF3PMrDxJ4vHeogGHGMARETWERXUvWLmmp/NXjpmNnQhS+mj5RmE3/aXCT0mM9XKHqx1t +K0iGlm1wUgjrYNXPn9sYCGEFdRn6U+OwEx9uduVgRVBDizfBC5zDNFt1rbpwtWXTffVgvcw6 3FQ8S6G/8ZEOSdmNs6laotiNKML/0qAFFn89cVCjuvfgdu5GYfQUYte4YRFAyJChBTjdFzuu/ xcod25dgX/67UfmE9lxBBryYmqgCa+/ay9hYcHe/cuFJqzFbl6vHtI07iv+EsT4XkLP959aI2 wsh6aDSl+swHHDFr/7aLWYnt3emk44DuZtpPHyvLFMmZDV9DCtM1/FfYVg0vwcmXl2p+E+82R /YR1dKe9i4zrwrbZh+pMjjGVATOWemEyOwfH49s6t87S/F9CJ+faDy8Q5JidlMWBRyLlcNMgF gxXgIK1Jo7CEq9vLOHsCRwgkwiOi/yY7rnTz7Tfe29DFike/BqlpW5TpJkrt3DTBJr0ZyhMmT Llr/+8fu/93F+yAn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 April 2016 21:52:48 Geert Uytterhoeven wrote: > > --- a/drivers/char/Kconfig > > +++ b/drivers/char/Kconfig > > @@ -279,8 +279,7 @@ if RTC_LIB=n > > > > config RTC > > tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)" > > - depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \ > > - && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML > > + depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300 > > Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter. > I listed it intentionally, to make it clearer to the reader what is going on. Actually MIPS as a dependency by itself would also be sufficient, because that contains select RTC_LIB if !MACH_LOONGSON64 and RTC depends on !RTC_LIB. Arnd