[PATH] Replace kmalloc+memset with kzalloc 1/17

[PATH] Replace kmalloc+memset with kzalloc 1/17

[Burman Yan]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi.

This is the first part of the patches I made that do trivial change of 
replacing
kmalloc and memset with kzalloc

Yan Burman

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

[-- Attachment #2: kzalloc_acpi.patch --]
[-- Type: application/octet-stream, Size: 21913 bytes --]

Replace kmalloc+memset with kzalloc 
Patch 1/17

Signed-off-by: Yan Burman <yan_952@hotmail.com>

diff -rubp linux-2.6.19-rc5_orig/arch/ia64/kernel/cpufreq/acpi-cpufreq.c linux-2.6.19-rc5_kzalloc/arch/ia64/kernel/cpufreq/acpi-cpufreq.c
--- linux-2.6.19-rc5_orig/arch/ia64/kernel/cpufreq/acpi-cpufreq.c	2006-11-09 12:16:22.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/arch/ia64/kernel/cpufreq/acpi-cpufreq.c	2006-11-11 22:44:04.000000000 +0200
@@ -279,12 +279,10 @@ acpi_cpufreq_cpu_init (
 
 	dprintk("acpi_cpufreq_cpu_init\n");
 
-	data = kmalloc(sizeof(struct cpufreq_acpi_io), GFP_KERNEL);
+	data = kzalloc(sizeof(struct cpufreq_acpi_io), GFP_KERNEL);
 	if (!data)
 		return (-ENOMEM);
 
-	memset(data, 0, sizeof(struct cpufreq_acpi_io));
-
 	acpi_io_data[cpu] = data;
 
 	result = acpi_processor_register_performance(&data->acpi_data, cpu);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/ac.c linux-2.6.19-rc5_kzalloc/drivers/acpi/ac.c
--- linux-2.6.19-rc5_orig/drivers/acpi/ac.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/ac.c	2006-11-11 22:44:04.000000000 +0200
@@ -221,10 +221,9 @@ static int acpi_ac_add(struct acpi_devic
 	if (!device)
 		return -EINVAL;
 
-	ac = kmalloc(sizeof(struct acpi_ac), GFP_KERNEL);
+	ac = kzalloc(sizeof(struct acpi_ac), GFP_KERNEL);
 	if (!ac)
 		return -ENOMEM;
-	memset(ac, 0, sizeof(struct acpi_ac));
 
 	ac->device = device;
 	strcpy(acpi_device_name(device), ACPI_AC_DEVICE_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/acpi_memhotplug.c linux-2.6.19-rc5_kzalloc/drivers/acpi/acpi_memhotplug.c
--- linux-2.6.19-rc5_orig/drivers/acpi/acpi_memhotplug.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/acpi_memhotplug.c	2006-11-11 22:44:04.000000000 +0200
@@ -395,10 +395,9 @@ static int acpi_memory_device_add(struct
 	if (!device)
 		return -EINVAL;
 
-	mem_device = kmalloc(sizeof(struct acpi_memory_device), GFP_KERNEL);
+	mem_device = kzalloc(sizeof(struct acpi_memory_device), GFP_KERNEL);
 	if (!mem_device)
 		return -ENOMEM;
-	memset(mem_device, 0, sizeof(struct acpi_memory_device));
 
 	INIT_LIST_HEAD(&mem_device->res_list);
 	mem_device->device = device;
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/asus_acpi.c linux-2.6.19-rc5_kzalloc/drivers/acpi/asus_acpi.c
--- linux-2.6.19-rc5_orig/drivers/acpi/asus_acpi.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/asus_acpi.c	2006-11-11 22:44:04.000000000 +0200
@@ -1253,10 +1253,9 @@ static int asus_hotk_add(struct acpi_dev
 	       ASUS_ACPI_VERSION);
 
 	hotk =
-	    (struct asus_hotk *)kmalloc(sizeof(struct asus_hotk), GFP_KERNEL);
+	    (struct asus_hotk *)kzalloc(sizeof(struct asus_hotk), GFP_KERNEL);
 	if (!hotk)
 		return -ENOMEM;
-	memset(hotk, 0, sizeof(struct asus_hotk));
 
 	hotk->handle = device->handle;
 	strcpy(acpi_device_name(device), ACPI_HOTK_DEVICE_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/battery.c linux-2.6.19-rc5_kzalloc/drivers/acpi/battery.c
--- linux-2.6.19-rc5_orig/drivers/acpi/battery.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/battery.c	2006-11-11 22:44:04.000000000 +0200
@@ -160,12 +160,11 @@ acpi_battery_get_info(struct acpi_batter
 		goto end;
 	}
 
-	data.pointer = kmalloc(data.length, GFP_KERNEL);
+	data.pointer = kzalloc(data.length, GFP_KERNEL);
 	if (!data.pointer) {
 		result = -ENOMEM;
 		goto end;
 	}
-	memset(data.pointer, 0, data.length);
 
 	status = acpi_extract_package(package, &format, &data);
 	if (ACPI_FAILURE(status)) {
@@ -220,12 +219,11 @@ acpi_battery_get_status(struct acpi_batt
 		goto end;
 	}
 
-	data.pointer = kmalloc(data.length, GFP_KERNEL);
+	data.pointer = kzalloc(data.length, GFP_KERNEL);
 	if (!data.pointer) {
 		result = -ENOMEM;
 		goto end;
 	}
-	memset(data.pointer, 0, data.length);
 
 	status = acpi_extract_package(package, &format, &data);
 	if (ACPI_FAILURE(status)) {
@@ -694,10 +692,9 @@ static int acpi_battery_add(struct acpi_
 	if (!device)
 		return -EINVAL;
 
-	battery = kmalloc(sizeof(struct acpi_battery), GFP_KERNEL);
+	battery = kzalloc(sizeof(struct acpi_battery), GFP_KERNEL);
 	if (!battery)
 		return -ENOMEM;
-	memset(battery, 0, sizeof(struct acpi_battery));
 
 	battery->device = device;
 	strcpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/button.c linux-2.6.19-rc5_kzalloc/drivers/acpi/button.c
--- linux-2.6.19-rc5_orig/drivers/acpi/button.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/button.c	2006-11-11 22:44:04.000000000 +0200
@@ -296,10 +296,9 @@ static int acpi_button_add(struct acpi_d
 	if (!device)
 		return -EINVAL;
 
-	button = kmalloc(sizeof(struct acpi_button), GFP_KERNEL);
+	button = kzalloc(sizeof(struct acpi_button), GFP_KERNEL);
 	if (!button)
 		return -ENOMEM;
-	memset(button, 0, sizeof(struct acpi_button));
 
 	button->device = device;
 	acpi_driver_data(device) = button;
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/container.c linux-2.6.19-rc5_kzalloc/drivers/acpi/container.c
--- linux-2.6.19-rc5_orig/drivers/acpi/container.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/container.c	2006-11-11 22:44:04.000000000 +0200
@@ -96,11 +96,10 @@ static int acpi_container_add(struct acp
 		return -EINVAL;
 	}
 
-	container = kmalloc(sizeof(struct acpi_container), GFP_KERNEL);
+	container = kzalloc(sizeof(struct acpi_container), GFP_KERNEL);
 	if (!container)
 		return -ENOMEM;
 
-	memset(container, 0, sizeof(struct acpi_container));
 	container->handle = device->handle;
 	strcpy(acpi_device_name(device), ACPI_CONTAINER_DEVICE_NAME);
 	strcpy(acpi_device_class(device), ACPI_CONTAINER_CLASS);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/ec.c linux-2.6.19-rc5_kzalloc/drivers/acpi/ec.c
--- linux-2.6.19-rc5_orig/drivers/acpi/ec.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/ec.c	2006-11-11 22:44:04.000000000 +0200
@@ -652,10 +652,9 @@ static int acpi_ec_add(struct acpi_devic
 	if (!device)
 		return -EINVAL;
 
-	ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
+	ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
 	if (!ec)
 		return -ENOMEM;
-	memset(ec, 0, sizeof(struct acpi_ec));
 
 	ec->handle = device->handle;
 	ec->uid = -1;
@@ -884,12 +883,11 @@ static int __init acpi_ec_fake_ecdt(void
 
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Try to make an fake ECDT"));
 
-	ec_ecdt = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
+	ec_ecdt = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
 	if (!ec_ecdt) {
 		ret = -ENOMEM;
 		goto error;
 	}
-	memset(ec_ecdt, 0, sizeof(struct acpi_ec));
 
 	status = acpi_get_devices(ACPI_EC_HID,
 				  acpi_fake_ecdt_callback, NULL, NULL);
@@ -921,10 +919,9 @@ static int __init acpi_ec_get_real_ecdt(
 	/*
 	 * Generate a temporary ec context to use until the namespace is scanned
 	 */
-	ec_ecdt = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
+	ec_ecdt = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
 	if (!ec_ecdt)
 		return -ENOMEM;
-	memset(ec_ecdt, 0, sizeof(struct acpi_ec));
 
 	init_MUTEX(&ec_ecdt->sem);
 	if (acpi_ec_mode == EC_INTR) {
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/fan.c linux-2.6.19-rc5_kzalloc/drivers/acpi/fan.c
--- linux-2.6.19-rc5_orig/drivers/acpi/fan.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/fan.c	2006-11-11 22:44:04.000000000 +0200
@@ -186,10 +186,9 @@ static int acpi_fan_add(struct acpi_devi
 	if (!device)
 		return -EINVAL;
 
-	fan = kmalloc(sizeof(struct acpi_fan), GFP_KERNEL);
+	fan = kzalloc(sizeof(struct acpi_fan), GFP_KERNEL);
 	if (!fan)
 		return -ENOMEM;
-	memset(fan, 0, sizeof(struct acpi_fan));
 
 	fan->device = device;
 	strcpy(acpi_device_name(device), "Fan");
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/i2c_ec.c linux-2.6.19-rc5_kzalloc/drivers/acpi/i2c_ec.c
--- linux-2.6.19-rc5_orig/drivers/acpi/i2c_ec.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/i2c_ec.c	2006-11-11 22:44:04.000000000 +0200
@@ -309,18 +309,16 @@ static int acpi_ec_hc_add(struct acpi_de
 		return -EINVAL;
 	}
 
-	ec_hc = kmalloc(sizeof(struct acpi_ec_hc), GFP_KERNEL);
+	ec_hc = kzalloc(sizeof(struct acpi_ec_hc), GFP_KERNEL);
 	if (!ec_hc) {
 		return -ENOMEM;
 	}
-	memset(ec_hc, 0, sizeof(struct acpi_ec_hc));
 
-	smbus = kmalloc(sizeof(struct acpi_ec_smbus), GFP_KERNEL);
+	smbus = kzalloc(sizeof(struct acpi_ec_smbus), GFP_KERNEL);
 	if (!smbus) {
 		kfree(ec_hc);
 		return -ENOMEM;
 	}
-	memset(smbus, 0, sizeof(struct acpi_ec_smbus));
 
 	ec_hc->handle = device->handle;
 	strcpy(acpi_device_name(device), ACPI_EC_HC_DEVICE_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/ibm_acpi.c linux-2.6.19-rc5_kzalloc/drivers/acpi/ibm_acpi.c
--- linux-2.6.19-rc5_orig/drivers/acpi/ibm_acpi.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/ibm_acpi.c	2006-11-11 22:44:04.000000000 +0200
@@ -1818,13 +1818,12 @@ static int __init register_driver(struct
 {
 	int ret;
 
-	ibm->driver = kmalloc(sizeof(struct acpi_driver), GFP_KERNEL);
+	ibm->driver = kzalloc(sizeof(struct acpi_driver), GFP_KERNEL);
 	if (!ibm->driver) {
 		printk(IBM_ERR "kmalloc(ibm->driver) failed\n");
 		return -1;
 	}
 
-	memset(ibm->driver, 0, sizeof(struct acpi_driver));
 	sprintf(ibm->driver->name, "%s/%s", IBM_NAME, ibm->name);
 	ibm->driver->ids = ibm->hid;
 	ibm->driver->ops.add = &ibm_device_add;
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/pci_bind.c linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_bind.c
--- linux-2.6.19-rc5_orig/drivers/acpi/pci_bind.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_bind.c	2006-11-11 22:44:04.000000000 +0200
@@ -122,19 +122,17 @@ int acpi_pci_bind(struct acpi_device *de
 	if (!device || !device->parent)
 		return -EINVAL;
 
-	pathname = kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
+	pathname = kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
 	if (!pathname)
 		return -ENOMEM;
-	memset(pathname, 0, ACPI_PATHNAME_MAX);
 	buffer.length = ACPI_PATHNAME_MAX;
 	buffer.pointer = pathname;
 
-	data = kmalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
+	data = kzalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
 	if (!data) {
 		kfree(pathname);
 		return -ENOMEM;
 	}
-	memset(data, 0, sizeof(struct acpi_pci_data));
 
 	acpi_get_name(device->handle, ACPI_FULL_PATHNAME, &buffer);
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Binding PCI device [%s]...\n",
@@ -281,10 +279,9 @@ int acpi_pci_unbind(struct acpi_device *
 	if (!device || !device->parent)
 		return -EINVAL;
 
-	pathname = (char *)kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
+	pathname = (char *)kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
 	if (!pathname)
 		return -ENOMEM;
-	memset(pathname, 0, ACPI_PATHNAME_MAX);
 
 	buffer.length = ACPI_PATHNAME_MAX;
 	buffer.pointer = pathname;
@@ -332,10 +329,9 @@ acpi_pci_bind_root(struct acpi_device *d
 	struct acpi_buffer buffer = { 0, NULL };
 
 
-	pathname = (char *)kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
+	pathname = (char *)kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
 	if (!pathname)
 		return -ENOMEM;
-	memset(pathname, 0, ACPI_PATHNAME_MAX);
 
 	buffer.length = ACPI_PATHNAME_MAX;
 	buffer.pointer = pathname;
@@ -345,12 +341,11 @@ acpi_pci_bind_root(struct acpi_device *d
 		return -EINVAL;
 	}
 
-	data = kmalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
+	data = kzalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
 	if (!data) {
 		kfree(pathname);
 		return -ENOMEM;
 	}
-	memset(data, 0, sizeof(struct acpi_pci_data));
 
 	data->id = *id;
 	data->bus = bus;
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/pci_irq.c linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_irq.c
--- linux-2.6.19-rc5_orig/drivers/acpi/pci_irq.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_irq.c	2006-11-11 22:44:04.000000000 +0200
@@ -89,10 +89,9 @@ acpi_pci_irq_add_entry(acpi_handle handl
 	if (!prt)
 		return -EINVAL;
 
-	entry = kmalloc(sizeof(struct acpi_prt_entry), GFP_KERNEL);
+	entry = kzalloc(sizeof(struct acpi_prt_entry), GFP_KERNEL);
 	if (!entry)
 		return -ENOMEM;
-	memset(entry, 0, sizeof(struct acpi_prt_entry));
 
 	entry->id.segment = segment;
 	entry->id.bus = bus;
@@ -161,10 +160,9 @@ int acpi_pci_irq_add_prt(acpi_handle han
 	static int first_time = 1;
 
 
-	pathname = (char *)kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
+	pathname = (char *)kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
 	if (!pathname)
 		return -ENOMEM;
-	memset(pathname, 0, ACPI_PATHNAME_MAX);
 
 	if (first_time) {
 		acpi_prt.count = 0;
@@ -198,11 +196,10 @@ int acpi_pci_irq_add_prt(acpi_handle han
 		return -ENODEV;
 	}
 
-	prt = kmalloc(buffer.length, GFP_KERNEL);
+	prt = kzalloc(buffer.length, GFP_KERNEL);
 	if (!prt) {
 		return -ENOMEM;
 	}
-	memset(prt, 0, buffer.length);
 	buffer.pointer = prt;
 
 	status = acpi_get_irq_routing_table(handle, &buffer);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/pci_link.c linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_link.c
--- linux-2.6.19-rc5_orig/drivers/acpi/pci_link.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_link.c	2006-11-11 22:44:04.000000000 +0200
@@ -307,11 +307,10 @@ static int acpi_pci_link_set(struct acpi
 	if (!link || !irq)
 		return -EINVAL;
 
-	resource = kmalloc(sizeof(*resource) + 1, irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL);
+	resource = kzalloc(sizeof(*resource) + 1, irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL);
 	if (!resource)
 		return -ENOMEM;
 
-	memset(resource, 0, sizeof(*resource) + 1);
 	buffer.length = sizeof(*resource) + 1;
 	buffer.pointer = resource;
 
@@ -718,10 +717,9 @@ static int acpi_pci_link_add(struct acpi
 	if (!device)
 		return -EINVAL;
 
-	link = kmalloc(sizeof(struct acpi_pci_link), GFP_KERNEL);
+	link = kzalloc(sizeof(struct acpi_pci_link), GFP_KERNEL);
 	if (!link)
 		return -ENOMEM;
-	memset(link, 0, sizeof(struct acpi_pci_link));
 
 	link->device = device;
 	strcpy(acpi_device_name(device), ACPI_PCI_LINK_DEVICE_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/pci_root.c linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_root.c
--- linux-2.6.19-rc5_orig/drivers/acpi/pci_root.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/pci_root.c	2006-11-11 22:44:04.000000000 +0200
@@ -164,10 +164,9 @@ static int acpi_pci_root_add(struct acpi
 	if (!device)
 		return -EINVAL;
 
-	root = kmalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
+	root = kzalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
 	if (!root)
 		return -ENOMEM;
-	memset(root, 0, sizeof(struct acpi_pci_root));
 	INIT_LIST_HEAD(&root->node);
 
 	root->device = device;
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/power.c linux-2.6.19-rc5_kzalloc/drivers/acpi/power.c
--- linux-2.6.19-rc5_orig/drivers/acpi/power.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/power.c	2006-11-11 22:44:04.000000000 +0200
@@ -532,10 +532,9 @@ static int acpi_power_add(struct acpi_de
 	if (!device)
 		return -EINVAL;
 
-	resource = kmalloc(sizeof(struct acpi_power_resource), GFP_KERNEL);
+	resource = kzalloc(sizeof(struct acpi_power_resource), GFP_KERNEL);
 	if (!resource)
 		return -ENOMEM;
-	memset(resource, 0, sizeof(struct acpi_power_resource));
 
 	resource->device = device;
 	strcpy(resource->name, device->pnp.bus_id);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/processor_core.c linux-2.6.19-rc5_kzalloc/drivers/acpi/processor_core.c
--- linux-2.6.19-rc5_orig/drivers/acpi/processor_core.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/processor_core.c	2006-11-11 22:44:04.000000000 +0200
@@ -615,10 +615,9 @@ static int acpi_processor_add(struct acp
 	if (!device)
 		return -EINVAL;
 
-	pr = kmalloc(sizeof(struct acpi_processor), GFP_KERNEL);
+	pr = kzalloc(sizeof(struct acpi_processor), GFP_KERNEL);
 	if (!pr)
 		return -ENOMEM;
-	memset(pr, 0, sizeof(struct acpi_processor));
 
 	pr->handle = device->handle;
 	strcpy(acpi_device_name(device), ACPI_PROCESSOR_DEVICE_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/sbs.c linux-2.6.19-rc5_kzalloc/drivers/acpi/sbs.c
--- linux-2.6.19-rc5_orig/drivers/acpi/sbs.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/sbs.c	2006-11-11 22:44:04.000000000 +0200
@@ -1576,12 +1576,11 @@ static int acpi_sbs_add(struct acpi_devi
 	int id, cnt;
 	acpi_status status = AE_OK;
 
-	sbs = kmalloc(sizeof(struct acpi_sbs), GFP_KERNEL);
+	sbs = kzalloc(sizeof(struct acpi_sbs), GFP_KERNEL);
 	if (!sbs) {
 		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "kmalloc() failed\n"));
 		return -ENOMEM;
 	}
-	memset(sbs, 0, sizeof(struct acpi_sbs));
 
 	cnt = 0;
 	while (cnt < 10) {
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/scan.c linux-2.6.19-rc5_kzalloc/drivers/acpi/scan.c
--- linux-2.6.19-rc5_orig/drivers/acpi/scan.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/scan.c	2006-11-11 22:44:04.000000000 +0200
@@ -984,12 +984,11 @@ acpi_add_single_object(struct acpi_devic
 	if (!child)
 		return -EINVAL;
 
-	device = kmalloc(sizeof(struct acpi_device), GFP_KERNEL);
+	device = kzalloc(sizeof(struct acpi_device), GFP_KERNEL);
 	if (!device) {
 		printk(KERN_ERR PREFIX "Memory allocation error\n");
 		return -ENOMEM;
 	}
-	memset(device, 0, sizeof(struct acpi_device));
 
 	device->handle = handle;
 	device->parent = parent;
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/thermal.c linux-2.6.19-rc5_kzalloc/drivers/acpi/thermal.c
--- linux-2.6.19-rc5_orig/drivers/acpi/thermal.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/thermal.c	2006-11-11 22:44:04.000000000 +0200
@@ -902,12 +902,10 @@ acpi_thermal_write_trip_points(struct fi
 	int i = 0;
 
 
-	limit_string = kmalloc(ACPI_THERMAL_MAX_LIMIT_STR_LEN, GFP_KERNEL);
+	limit_string = kzalloc(ACPI_THERMAL_MAX_LIMIT_STR_LEN, GFP_KERNEL);
 	if (!limit_string)
 		return -ENOMEM;
 
-	memset(limit_string, 0, ACPI_THERMAL_MAX_LIMIT_STR_LEN);
-
 	active = kmalloc(ACPI_THERMAL_MAX_ACTIVE * sizeof(int), GFP_KERNEL);
 	if (!active) {
 		kfree(limit_string);
@@ -1271,10 +1269,9 @@ static int acpi_thermal_add(struct acpi_
 	if (!device)
 		return -EINVAL;
 
-	tz = kmalloc(sizeof(struct acpi_thermal), GFP_KERNEL);
+	tz = kzalloc(sizeof(struct acpi_thermal), GFP_KERNEL);
 	if (!tz)
 		return -ENOMEM;
-	memset(tz, 0, sizeof(struct acpi_thermal));
 
 	tz->device = device;
 	strcpy(tz->name, device->pnp.bus_id);
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/utils.c linux-2.6.19-rc5_kzalloc/drivers/acpi/utils.c
--- linux-2.6.19-rc5_orig/drivers/acpi/utils.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/utils.c	2006-11-11 22:44:04.000000000 +0200
@@ -262,11 +262,10 @@ acpi_evaluate_integer(acpi_handle handle
 	if (!data)
 		return AE_BAD_PARAMETER;
 
-	element = kmalloc(sizeof(union acpi_object), irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL);
+	element = kzalloc(sizeof(union acpi_object), irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL);
 	if (!element)
 		return AE_NO_MEMORY;
 
-	memset(element, 0, sizeof(union acpi_object));
 	buffer.length = sizeof(union acpi_object);
 	buffer.pointer = element;
 	status = acpi_evaluate_object(handle, pathname, arguments, &buffer);
@@ -321,12 +320,11 @@ acpi_evaluate_string(acpi_handle handle,
 		return AE_BAD_DATA;
 	}
 
-	*data = kmalloc(element->string.length + 1, GFP_KERNEL);
+	*data = kzalloc(element->string.length + 1, GFP_KERNEL);
 	if (!data) {
 		printk(KERN_ERR PREFIX "Memory allocation\n");
 		return -ENOMEM;
 	}
-	memset(*data, 0, element->string.length + 1);
 
 	memcpy(*data, element->string.pointer, element->string.length);
 
diff -rubp linux-2.6.19-rc5_orig/drivers/acpi/video.c linux-2.6.19-rc5_kzalloc/drivers/acpi/video.c
--- linux-2.6.19-rc5_orig/drivers/acpi/video.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/acpi/video.c	2006-11-11 22:44:04.000000000 +0200
@@ -532,11 +532,10 @@ static void acpi_video_device_find_cap(s
 		int count = 0;
 		union acpi_object *o;
 
-		br = kmalloc(sizeof(*br), GFP_KERNEL);
+		br = kzalloc(sizeof(*br), GFP_KERNEL);
 		if (!br) {
 			printk(KERN_ERR "can't allocate memory\n");
 		} else {
-			memset(br, 0, sizeof(*br));
 			br->levels = kmalloc(obj->package.count *
 					     sizeof *(br->levels), GFP_KERNEL);
 			if (!br->levels)
@@ -1263,12 +1262,10 @@ acpi_video_bus_get_one_device(struct acp
 	    acpi_evaluate_integer(device->handle, "_ADR", NULL, &device_id);
 	if (ACPI_SUCCESS(status)) {
 
-		data = kmalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
+		data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
 		if (!data)
 			return -ENOMEM;
 
-		memset(data, 0, sizeof(struct acpi_video_device));
-
 		strcpy(acpi_device_name(device), ACPI_VIDEO_DEVICE_NAME);
 		strcpy(acpi_device_class(device), ACPI_VIDEO_CLASS);
 		acpi_driver_data(device) = data;
@@ -1696,10 +1693,9 @@ static int acpi_video_bus_add(struct acp
 	if (!device)
 		return -EINVAL;
 
-	video = kmalloc(sizeof(struct acpi_video_bus), GFP_KERNEL);
+	video = kzalloc(sizeof(struct acpi_video_bus), GFP_KERNEL);
 	if (!video)
 		return -ENOMEM;
-	memset(video, 0, sizeof(struct acpi_video_bus));
 
 	video->device = device;
 	strcpy(acpi_device_name(device), ACPI_VIDEO_BUS_NAME);
diff -rubp linux-2.6.19-rc5_orig/drivers/pci/hotplug/acpiphp_ibm.c linux-2.6.19-rc5_kzalloc/drivers/pci/hotplug/acpiphp_ibm.c
--- linux-2.6.19-rc5_orig/drivers/pci/hotplug/acpiphp_ibm.c	2006-11-09 12:16:21.000000000 +0200
+++ linux-2.6.19-rc5_kzalloc/drivers/pci/hotplug/acpiphp_ibm.c	2006-11-11 22:44:04.000000000 +0200
@@ -319,13 +319,12 @@ static int ibm_get_table_from_acpi(char 
 	if (bufp == NULL)
 		goto read_table_done;
 
-	lbuf = kmalloc(size, GFP_KERNEL);
+	lbuf = kzalloc(size, GFP_KERNEL);
 	dbg("%s: element count: %i, ASL table size: %i, &table = 0x%p\n",
 			__FUNCTION__, package->package.count, size, lbuf);
 
 	if (lbuf) {
 		*bufp = lbuf;
-		memset(lbuf, 0, size);
 	} else {
 		size = -ENOMEM;
 		goto read_table_done;

Re: [PATH] Replace kmalloc+memset with kzalloc 1/17

[Russell King]

On Sun, Nov 12, 2006 at 07:20:53PM +0200, Burman Yan wrote:
> This is the first part of the patches I made that do trivial change of 
> replacing
> kmalloc and memset with kzalloc

Please follow the guidelines in SubmittingPatches in the kernel source
when sending patches out.  You must not expect everyone here to read
each of the attachments in your messages in detail to work out whether
they need to do something with it or not.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

Re: [PATH] Replace kmalloc+memset with kzalloc 1/17

[Randy Dunlap]

On Sun, 12 Nov 2006 17:31:03 +0000 Russell King wrote:

> On Sun, Nov 12, 2006 at 07:20:53PM +0200, Burman Yan wrote:
> > This is the first part of the patches I made that do trivial change of 
> > replacing
> > kmalloc and memset with kzalloc
> 
> Please follow the guidelines in SubmittingPatches in the kernel source
> when sending patches out.  You must not expect everyone here to read
> each of the attachments in your messages in detail to work out whether
> they need to do something with it or not.

You should also use a different subject for each one,
something that is related to the subsystem being patched,
e.g., [PATCH] scsi: use kzalloc

Besides Documentation/SubmittingPatches, please also read
http://linux.yyz.us/patch-format.html
and http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

---
~Randy

Re: [PATH] Replace kmalloc+memset with kzalloc 1/17

[Burman Yan]

OK.
Sorry.

I had to attach the patch, since hotmail does line wrapping, but I will note 
the part regarding
the more descriptive subject.

Also, some of the patches are one line per file, so I joined them together 
in one single patch.
I thought that splitting that into many tiny patches will actually be more 
annoying than
a single bigger patch.

Does that mean I should send those patches again?

>From: Russell King <rmk+lkml@arm.linux.org.uk>
>To: Burman Yan <yan_952@hotmail.com>
>CC: trivial@kernel.org, linux-kernel@vger.kernel.org
>Subject: Re: [PATH] Replace kmalloc+memset with kzalloc 1/17
>Date: Sun, 12 Nov 2006 17:31:03 +0000
>
>On Sun, Nov 12, 2006 at 07:20:53PM +0200, Burman Yan wrote:
> > This is the first part of the patches I made that do trivial change of
> > replacing
> > kmalloc and memset with kzalloc
>
>Please follow the guidelines in SubmittingPatches in the kernel source
>when sending patches out.  You must not expect everyone here to read
>each of the attachments in your messages in detail to work out whether
>they need to do something with it or not.
>
>--
>Russell King
>  Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
>  maintainer of:  2.6 Serial core

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

Re: [PATH] Replace kmalloc+memset with kzalloc 1/17

[Jan Engelhardt]

>> > This is the first part of the patches I made that do trivial change of 
>> > replacing
>> > kmalloc and memset with kzalloc
>> 
>> Please follow the guidelines in SubmittingPatches in the kernel source
>> when sending patches out.  You must not expect everyone here to read
>> each of the attachments in your messages in detail to work out whether
>> they need to do something with it or not.
>
>You should also use a different subject for each one,


And if possible, attach it using a text/plain mime type or text/x-patch 
instead of application/octet-stream. Because if it's octet-stream, PINE 
won't let me view it in an instant (gotta export it first).


	-`J'
-- 

Re: [PATH] Replace kmalloc+memset with kzalloc 1/17

[Paulo Marques]

Burman Yan wrote:
> OK.
> Sorry.
> 
> I had to attach the patch, since hotmail does line wrapping, but I will 
> note the part regarding
> the more descriptive subject.

Hotmail is probably the _worse_ email client you could use to send 
patches to the kernel.

> Also, some of the patches are one line per file, so I joined them 
> together in one single patch.
> I thought that splitting that into many tiny patches will actually be 
> more annoying than
> a single bigger patch.

The logical separation you did isn't bad, but there is no mention on the 
*subject line* what section is targeted by your patch.

Also you should CC the maintainer for each section you're targeting. For 
instance, for the ACPI patch you should also CC Len Brown. Check the 
MAINTAINERS file for the right people to CC on each patch.

> Does that mean I should send those patches again?

Afraid so.

While you're at it, you could remove casts like this one:

-	pathname = (char *)kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
+	pathname = (char *)kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
  	if (!pathname)
  		return -ENOMEM;
-	memset(pathname, 0, ACPI_PATHNAME_MAX);

That "(char *)" really isn't needed.

Oh, and just one more thing: don't top post.

-- 
Paulo Marques - www.grupopie.com

"The face of a child can say it all, especially the
mouth part of the face."