From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Pankaj Patil <pankaj.patil@oss.qualcomm.com>,
sboyd@kernel.org, mturquette@baylibre.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
quic_rjendra@quicinc.com, taniya.das@oss.qualcomm.com,
linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] clk: qcom: gcc: Add support for Global Clock Controller
Date: Sun, 20 Jul 2025 14:18:19 +0200 [thread overview]
Message-ID: <4559a710-8b4f-4988-b063-40486fe0ffe2@kernel.org> (raw)
In-Reply-To: <2yekmjqihkzsfjr223vepigfj4hfruleigguhrlekp6s7riuxk@ta5kghr2kafi>
On 20/07/2025 05:46, Bjorn Andersson wrote:
> On Wed, Jul 16, 2025 at 06:28:15PM +0200, Krzysztof Kozlowski wrote:
>> On 16/07/2025 17:20, Pankaj Patil wrote:
> [..]
>>> diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c
>>> new file mode 100644
>>> index 000000000000..a1a6da62ed35
>>> --- /dev/null
>>> +++ b/drivers/clk/qcom/gcc-glymur.c
>>> @@ -0,0 +1,8623 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>>
>> Missing date.
>>
>
> Per updated company guidelines we don't want a year here. Please let us
> know if you have any concerns with this.
>
I remember the guidelines and they were about publishing your code, not
about contributing to open-source projects. And whatever you have
internally does not cover us at all. You can have internal guideline
saying you need to buy me a beer or I need to buy you a beer. Does not
matter.
That above copyright statement without date does not adhere to expected
format. Explanation how this should be written:
https://www.gnu.org/licenses/gpl-howto.en.html#copyright-notice
The GPL-2.0 license in the kernel also uses date:
"Copyright (C) <year> <name of author> "
There is no option without date in the license or GPL faq. I am not a
lawyer, so no clue whether this is what we want, but I also should not
be my task to figure out whether different copyright statement is okay
or not. It's your burden.
Or drop the Copyright statement complete to avoid any questions.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-20 12:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 15:20 [PATCH 0/7] Add support for Clock controllers for Glymur Pankaj Patil
2025-07-16 15:20 ` [PATCH 1/7] dt-bindings: clock: qcom-rpmhcc: Add support for Glymur SoCs Pankaj Patil
2025-07-16 15:20 ` [PATCH 2/7] dt-bindings: clock: qcom: Add bindings documentation for the Glymur TCSR Pankaj Patil
2025-07-21 9:19 ` Krzysztof Kozlowski
2025-07-23 9:21 ` Taniya Das
2025-07-16 15:20 ` [PATCH 3/7] clk: qcom: Add TCSR clock driver for Glymur Pankaj Patil
2025-07-16 15:35 ` Dmitry Baryshkov
2025-07-18 17:06 ` Taniya Das
2025-07-16 15:20 ` [PATCH 4/7] clk: qcom: rpmh: Add support for Glymur rpmh clocks Pankaj Patil
2025-07-16 15:20 ` [PATCH 5/7] clk: qcom: clk-alpha-pll: Add support for Taycan EKO_T PLL Pankaj Patil
2025-07-16 15:36 ` Dmitry Baryshkov
2025-07-16 15:20 ` [PATCH 6/7] dt-bindings: clock: qcom: document the Glymur Global Clock Controller Pankaj Patil
2025-07-16 15:20 ` [PATCH 7/7] clk: qcom: gcc: Add support for " Pankaj Patil
2025-07-16 16:28 ` Krzysztof Kozlowski
2025-07-18 17:26 ` Taniya Das
2025-07-20 3:46 ` Bjorn Andersson
2025-07-20 12:18 ` Krzysztof Kozlowski [this message]
2025-07-22 3:28 ` Bjorn Andersson
2025-08-13 16:19 ` Greg KH
2025-08-14 22:51 ` Bjorn Andersson
2025-07-17 9:57 ` Abel Vesa
2025-07-17 10:08 ` Krzysztof Kozlowski
2025-07-18 17:37 ` Taniya Das
2025-07-20 4:00 ` Bjorn Andersson
2025-07-21 17:13 ` Taniya Das
2025-07-22 3:21 ` Bjorn Andersson
2025-07-16 16:12 ` [PATCH 0/7] Add support for Clock controllers for Glymur Krzysztof Kozlowski
2025-07-21 6:38 ` Pankaj Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4559a710-8b4f-4988-b063-40486fe0ffe2@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).