From: Jeff Garzik <jeff@garzik.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexis Bruemmer <alexisb@us.ibm.com>
Subject: Re: [PATCH] sas_ata: satisfy libata qc function locking requirements
Date: Tue, 14 Nov 2006 18:07:03 -0500 [thread overview]
Message-ID: <455A4C17.5000902@garzik.org> (raw)
In-Reply-To: <455A395D.1060407@us.ibm.com>
Darrick J. Wong wrote:
> ata_qc_complete and ata_sas_queuecmd require that the port lock be held
> when they are called. sas_ata doesn't do this, leading to BUG messages
> about qc tags newly allocated qc tags already being in use. This patch
> fixes the locking, which should clean up the rest of those messages.
>
> So far I've tested this against an IBM x206m with two SATA disks with no
> BUG messages and no other signs of things going wrong, and the machine
> finally passed the pounder stress test. The patch is against jejb's
> aic94xx-sas tree.
>
> --
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
heh, yeah, proper locking helps :)
Glad to hear the progress. Adaptec just sent me a cable that will allow
me to use my Razor card as a SATA controller, so I can finally start
testing that.
Jeff
prev parent reply other threads:[~2006-11-14 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 21:47 [PATCH] sas_ata: satisfy libata qc function locking requirements Darrick J. Wong
2006-11-14 23:07 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455A4C17.5000902@garzik.org \
--to=jeff@garzik.org \
--cc=alexisb@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox