From: Phillip Susi <psusi@cfl.rr.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Mathieu Fluhr <mfluhr@nero.com>,
Arjan van de Ven <arjan@infradead.org>,
jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: READ SCSI cmd seems to fail on SATA optical devices...
Date: Wed, 15 Nov 2006 11:17:29 -0500 [thread overview]
Message-ID: <455B3D99.8040705@cfl.rr.com> (raw)
In-Reply-To: <455B3A78.7010503@gmail.com>
Tejun Heo wrote:
>> The patch _seems_ to solve my problem. I am just really astonished when
>> I read the diff file :D. Can I expect that it will be merged to the
>> official kernel sources ?
>
> It seems that some devices choke when the bytes after CDB contain
> garbage. I seem to recall that I read somewhere ATAPI device require
> left command bytes cleared to zero but I can't find it anywhere now.
> Maybe I'm just imagining. Anyways, yeah, I'll push it to upstream.
>
The original patch memsets the entire buffer only to copy over most of
it right after. Could you amend the patch so that it memcpys first,
then memsets only the remainder of the buffer? No sense wasting cpu
cycles.
next prev parent reply other threads:[~2006-11-15 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 16:19 READ SCSI cmd seems to fail on SATA optical devices Mathieu Fluhr
2006-11-13 18:49 ` Phillip Susi
2006-11-13 18:56 ` Mathieu Fluhr
2006-11-13 19:32 ` Arjan van de Ven
2006-11-14 15:45 ` Mathieu Fluhr
2006-11-14 17:24 ` Tejun Heo
2006-11-15 15:19 ` Mathieu Fluhr
2006-11-15 16:04 ` Tejun Heo
2006-11-15 16:17 ` Phillip Susi [this message]
2006-11-15 16:20 ` Arjan van de Ven
2006-11-15 16:28 ` Alan
2006-11-14 2:02 ` Tejun Heo
2006-11-14 10:08 ` Mathieu Fluhr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455B3D99.8040705@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=arjan@infradead.org \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfluhr@nero.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox