From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757044AbcEEK5l (ORCPT ); Thu, 5 May 2016 06:57:41 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:54701 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756675AbcEEK5j (ORCPT ); Thu, 5 May 2016 06:57:39 -0400 From: Arnd Bergmann To: Vineet Gupta Cc: Horia =?utf-8?B?R2VhbnTEgw==?= , Herbert Xu , "linux-crypto@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Scott Wood , Alexandru Porosanu , Tudor Ambarus , Cristian Stoica , arcml , Noam Camus Subject: Re: [PATCH 1/7] asm-generic/io.h: add io{read,write}64 accessors Date: Thu, 05 May 2016 12:56:48 +0200 Message-ID: <4560398.4eHNWD6mu5@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1462382179-11889-1-git-send-email-horia.geanta@nxp.com> <16429831.u9JK7qO1GE@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:z4y49KY9HXEQsCkFhZ4yMNZ0aG8JqoID+jj8PHVIWgmis42GmR8 RHUco59r07mM2mPVhvCYm7fG5PdKi+ez7wBaXklyVenc3wzdVvfHU/fFdnSz/7NhVG1KUAH 1+9z4IAFU8+BBedTtjdOHjfHRyMjJZPDNx12DKj5ENlu+EBPYvXWNa+yef0nqGjwdLKvgsS Rjzr0r36Ufh9grbEKABnQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:SyZ2tCBT6xE=:jriUt4YE3PzIaA1kBcafGM RCmLCP0cjW96OTyoS4PWxHeX+w09JgtQEqVw1pMhS33gPyYpRrLFf9EXHzlRb74PL2n904UWQ uBawtW3lO/6Rv7yrH4P7zfhQKlgwdF38+5dEksyyR4mSVjeBx9Ealq9qqrr6Fs/D/zZMzeKL9 jEY4yrN5qkF/QGJddwz9DFBzcOzhbUPahdWqiCWTS9vdP0tGJEUp+Y6rw7+QfMmTxgSy5uUUO TgQusJ2vplN60d6zo09GuBJ5gJB/MfYWavJIH1V8dZtOKWCmdy4GamIXv9FB6ZAq1vzF7Kddr qaFY6+MoIqoIgpuCUaDohGHYMonk9f0VafJdPvuYhTXZQji1lD8bU0yXve+q+LJlErTx8yJoe UUVN1c1IKipiuJiO5oHGMg/tmgm3b4d6BzfzyfR8uoizxjNF9r3ZEFmHkBX8tBTvnmwx1JA/W dof2mJ/QMwwe48LRo7GqFwKefClUF2rAH/qUgC9l7rbyqVtQyrpWoeeUZwbhTZWaIxLf7957H uXYvxSPirPHhan3WgC7yecRN6EX2bHWC8++0uu+66x9WljMfFQJ2rQepcTyyYOsXCalTrkfOn iE1GuKhl5GEKJQRLFoka3V96/BSPWEDIfWawf831TPNJAlaMo7dlzZFjNU3RmgqG0PjaWIFQY icFvWG/xxkCIghbPNs0fGLcd8dBUZD2Mes4gE8Be4ssJj4YrIISGPeDgQ0Ei/GtxqoRoiy2i6 XCcAaS8H/EISYBmY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 05 May 2016 08:16:47 Vineet Gupta wrote: > Thx for noticing this Arnd and the heads up. Does the patch below look ok to you ? > > -----------> > rom b7e719831c389ab4fa338b2e2e7c0d1ff90dabb0 Mon Sep 17 00:00:00 2001 > From: Vineet Gupta > Date: Thu, 5 May 2016 13:32:34 +0530 > Subject: [PATCH] ARC: Add missing io barriers to io{read,write}{16,32}be() > > While reviewing a different change to asm-generic/io.h Arnd spotted that > ARC ioread32 and ioread32be both of which come from asm-generic versions > are not symmetrical in terms of calling the io barriers. > > generic ioread32 -> ARC readl() [ has barriers] > generic ioread32be -> __be32_to_cpu(__raw_readl()) [ lacks barriers] > > While generic ioread32be is being remediated to call readl(), that involves > a swab32(), causing double swaps on ioread32be() on Big Endian systems. > > So provide our versions of big endian IO accessors to ensure io barrier > calls while also keeping them optimal > > Suggested-by: Arnd Bergmann > Cc: stable@vger.kernel.org [4.2+] > Signed-off-by: Vineet Gupta Yes, that looks correct. We probably want this regardless of the change I proposed for the generic file, to avoid the double swap. Acked-by: Arnd Bergmann