Re: reiserfs NET=n build error

[Jeff Mahoney <jeffm@suse.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andi Kleen wrote:
> On Sunday 19 November 2006 05:22, Randy Dunlap wrote:
>> With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with
>>
>> Kernel: arch/x86_64/boot/bzImage is ready  (#15)
>>   Building modules, stage 2.
>>   MODPOST 137 modules
>> WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>>
>> on both 2.6.19-rc6 and 2.6.19-rc6-git2.
>>
>> Looks like arch/x86_64/lib/lib.a is not being linked into the
>> final kernel image for some reason.  lib.a does contain csum_partial.
> 
> iirc Al Viro has been cleaning that up. Essentially reiserfs should
> use its own C copy of the checksum functions. Using csum_partial() is not
> safe because its output varies by architecture.
> 
> I would copy a relatively simple C implementation, like arch/h8300/lib/checksum.c

As long as the h8300 version has the same output as the x86 version.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFYI/BLPWxlyuTD7IRAjveAJ0U+D3PO6h+2z83ZG9ZLay3q5JBFACcDHFQ
hIaiIBCFzfHg9qak9cxUtRo=
=GuqM
-----END PGP SIGNATURE-----