Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

David Brownell
2006-12-28T20:48:25Z

On Wednesday 27 December 2006 9:53 am, Pavel Machek wrote:
> Hi!
>
> > Arch-neutral GPIO calls for PXA.
> >
> > From: Philipp Zabel <philipp.zabel@gmail.com>
>
> Missing s-o-b?

Yes, still ...

> > +static inline int gpio_direction_input(unsigned gpio)
> > +{
> > + if (gpio > PXA_LAST_GPIO)
> > + return -EINVAL;
> > + pxa_gpio_mode(gpio | GPIO_IN);
> > +}
>
> Missing return 0?
>
> > +static inline int gpio_direction_output(unsigned gpio)
> > +{
> > + if (gpio > PXA_LAST_GPIO)
> > + return -EINVAL;
> > + pxa_gpio_mode(gpio | GPIO_OUT);
> > +}
> > +
>
> And here?

You're looking at about the oldest version of that patch.
Admittedly there were too many floating around...