Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

Pavel Machek
2006-12-28T08:39:41Z

Hi!

> +static inline int gpio_direction_input(unsigned gpio)
> +{
> + if (gpio > GPIO_MAX)
> + return -EINVAL;
> + GPDR = (GPDR_In << gpio) 0
> +}

Missing return 0.

> +static inline int gpio_direction_output(unsigned gpio)
> +{
> + if (gpio > GPIO_MAX)
> + return -EINVAL;
> + GPDR = (GPDR_Out << gpio) 0
> +}

Here too.

--
Thanks for all the (sleeping) penguins.