Re: [patch 2.6.20-rc1 3/6] AT91 GPIO wrappers

David Brownell
2006-12-21T06:45:25Z

On Wednesday 20 December 2006 10:10 pm, Andrew Morton wrote:
> On Wed, 20 Dec 2006 13:11:19 -0800
> David Brownell <david-b@pacbell.net> wrote:
>
> > +static inline int gpio_get_value(unsigned gpio)
> > + { return at91_get_gpio_value(gpio); }
> > +
> > +static inline void gpio_set_value(unsigned gpio, int value)
> > + { (void) at91_set_gpio_value(gpio, value); }
>
> whaa? Where'd we pull that coding style from?

School of concision. Notice also the clever ";) at the end of each line.

> Please,

I see you fixed this in what you merged to MM; thanks.

- Dave

> static inline int gpio_get_value(unsigned gpio)
> {
> return at91_get_gpio_value(gpio);
> }
>
> static inline void gpio_set_value(unsigned gpio, int value)
> {
> at91_set_gpio_value(gpio, value);
> }
>