Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

Pavel Machek
2006-12-28T20:53:57Z

On Thu 2006-12-28 21:50:55, Pavel Machek wrote:
> Hi!
>
> > > > From: Philipp Zabel <philipp.zabel@gmail.com>
> > >
> > > Missing s-o-b?
> >
> > Yes, still ...
> >
> > > > +static inline int gpio_direction_input(unsigned gpio)
> > > > +{
> > > > + if (gpio > PXA_LAST_GPIO)
> > > > + return -EINVAL;
> > > > + pxa_gpio_mode(gpio | GPIO_IN);
> > > > +}
> > >
> > > Missing return 0?
> > >
> > > > +static inline int gpio_direction_output(unsigned gpio)
> > > > +{
> > > > + if (gpio > PXA_LAST_GPIO)
> > > > + return -EINVAL;
> > > > + pxa_gpio_mode(gpio | GPIO_OUT);
> > > > +}
> > > > +
> > >
> > > And here?
> >
> > You're looking at about the oldest version of that patch.
> > Admittedly there were too many floating around...
>
> I think I've looked at the newer ones, too, and this particular return
> was _not_ fixed.

Ok, I was wrong, the very newest one seems to be okay.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html