Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

Andrew Morton
2006-12-21T06:13:27Z

On Wed, 20 Dec 2006 13:12:35 -0800
David Brownell <david-b@pacbell.net> wrote:

> +/* REVISIT these macros are correct, but suffer code explosion
> + * for non-constant parameters. Provide out-line versions too.
> + */
> +#define gpio_get_value(gpio) \
> + (GPLR(gpio) & GPIO_bit(gpio))
> +
> +#define gpio_set_value(gpio,value) \
> + ((value) ? (GPSR(gpio) = GPIO_bit(gpio)):(GPCR(gpio) = GPIO_bit(gpio)))

Why not implement them as inline functions?

Or non-inline functions, come to that.

Either way, programming in C is preferable to this ;)