Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

Pavel Machek
2006-12-28T08:38:57Z

Hi!

> Arch-neutral GPIO calls for PXA.
>
> From: Philipp Zabel <philipp.zabel@gmail.com>

Missing s-o-b?

> +static inline int gpio_direction_input(unsigned gpio)
> +{
> + if (gpio > PXA_LAST_GPIO)
> + return -EINVAL;
> + pxa_gpio_mode(gpio | GPIO_IN);
> +}

Missing return 0?

> +static inline int gpio_direction_output(unsigned gpio)
> +{
> + if (gpio > PXA_LAST_GPIO)
> + return -EINVAL;
> + pxa_gpio_mode(gpio | GPIO_OUT);
> +}
> +

And here?

Pavel
--
Thanks for all the (sleeping) penguins.