From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, ltt-dev@shafik.org,
mgreer@mvista.com, mlachwani@mvista.com
Subject: Re: LTTng do_page_fault vs handle_mm_fault instrumentation
Date: Tue, 21 Nov 2006 20:12:00 +0300 [thread overview]
Message-ID: <45633360.6080109@ru.mvista.com> (raw)
In-Reply-To: <20061121170317.GA10250@Krystal>
Hello.
Mathieu Desnoyers wrote:
> Instrumentation around the handle_mm_fault handler call, inside do_page_fault,
> looked to me as a good compromise : it can access the struct pt_regs, it will
> never be called from either a vmalloc fault or an erroneous page fault caused by
> the tracer itself (which of course, never happens, but who knows...). It won't,
> however, give information about some error paths in the page fault handler,
> mainly related to kernel faults. It is also a little farther from the page
> fault handler "real" entry and exit points, but I consider it a minor impact
> compared to the cost of entering the trap on currently existing architectures.
I kept this approach mostly (note it would have been hard to change it due
to this particular handler's structure itself) but just cleaned it up. If you
consider that adding more markers was a bit too much, I can remove them. :-)
WBR, Sergei
prev parent reply other threads:[~2006-11-21 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 16:06 LTTng do_page_fault vs handle_mm_fault instrumentation Mathieu Desnoyers
2006-11-21 16:26 ` Sergei Shtylyov
2006-11-21 17:03 ` Mathieu Desnoyers
2006-11-21 17:12 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45633360.6080109@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=compudj@krystal.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=mgreer@mvista.com \
--cc=mingo@elte.hu \
--cc=mlachwani@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox