From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Alex Dubov <oakad@yahoo.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/1] MMC: new version of the TI Flash Media card reader driver
Date: Wed, 22 Nov 2006 07:42:20 +0100 [thread overview]
Message-ID: <4563F14C.9060100@drzeus.cx> (raw)
In-Reply-To: <281931.6630.qm@web36709.mail.mud.yahoo.com>
Alex Dubov wrote:
> I know that the patch is too big, but I have no way to split it up. Basically, I've changed so
> many things (I had quite a few problems with interrupts after suspend/resume) that it can be
> regarded as a brand new driver. My SVN became somewhat messy too.
>
> I can post the driver in it full (non-diff) form or as a 4 per-file diffs, but I have no way to
> split it up into per-issue form (except for issues 3 and 5, which are one-liners).
>
That's a start. But 4 sounds like it could be broken out with some work.
I'm not saying it's trivial to break this apart, but it is something
that needs to be done. At the very least the commit messages need to
reflect what is changed and why.
See it as practice as this is an issue you will be hit by now and then
as a kernel developer. :)
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next parent reply other threads:[~2006-11-22 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <281931.6630.qm@web36709.mail.mud.yahoo.com>
2006-11-22 6:42 ` Pierre Ossman [this message]
2007-01-07 14:56 ` [PATCH 1/1] MMC: new version of the TI Flash Media card reader driver Fabio Comolli
2006-10-29 6:52 [2.6.19-rc2-mm2] oops removing sd card Fabio Comolli
2006-11-21 15:56 ` [PATCH 1/1] MMC: new version of the TI Flash Media card reader driver Alex Dubov
2006-11-21 17:09 ` Pierre Ossman
2006-11-21 21:31 ` Fabio Comolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4563F14C.9060100@drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox