public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: "Sébastien Dugué" <sebastien.dugue@bull.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-aio <linux-aio@kvack.org>, Andrew Morton <akpm@osdl.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Badari Pulavarty <pbadari@us.ibm.com>,
	Jean Pierre Dion <jean-pierre.dion@bull.net>,
	Ulrich Drepper <drepper@redhat.com>
Subject: Re: [PATCH -mm 3/4][AIO] - AIO completion signal notification
Date: Wed, 22 Nov 2006 02:22:15 -0800	[thread overview]
Message-ID: <456424D7.7060204@oracle.com> (raw)
In-Reply-To: <20061122104055.3d1c029a@frecb000686>


>   OK, looking at this, there's something bothering me: io_submit_one() needs
> a pointer to the user iocb in order to push back the iocb->ki_key to userspace,
> as well as storing the user_iocb pointer into iocb->ki_obj.

Why can't it continue to do what it does today?  Both of those uses of
the user_iocb pointer involve fixed-width fields and don't need compat help.

>   So I think that some of the logic in io_submit_one() must be moved up to
> sys_io_submit(), including the aio_get_req() call.

I don't see why that would be needed.

- z

  parent reply	other threads:[~2006-11-22 18:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 14:17 [PATCH -mm 0/4][AIO] - AIO completion signal notification v2 Sébastien Dugué
2006-11-20 14:22 ` [PATCH -mm 1/4][AIO] - fix aio.h includes Sébastien Dugué
2006-11-20 13:31   ` Zach Brown
2006-11-20 14:22 ` [PATCH -mm 2/4][AIO] - export good_sigevent() Sébastien Dugué
2006-11-20 13:42   ` Zach Brown
2006-11-20 21:45     ` Ulrich Drepper
2006-11-20 14:02       ` Zach Brown
2006-11-20 14:22 ` [PATCH -mm 3/4][AIO] - AIO completion signal notification Sébastien Dugué
2006-11-20 15:13   ` Zach Brown
2006-11-21 10:40     ` Sébastien Dugué
     [not found]     ` <20061122104055.3d1c029a@frecb000686>
2006-11-22 10:22       ` Zach Brown [this message]
2006-11-23  8:24         ` Sébastien Dugué
2006-11-22  1:02   ` Andrew Morton
2006-11-23  8:28     ` Sébastien Dugué
2006-11-23  8:40       ` Andrew Morton
2006-11-23  9:47         ` Sébastien Dugué
2006-11-23 10:14           ` Andrew Morton
2006-11-23 10:27             ` Sébastien Dugué
2006-11-23 10:57         ` [PATCH] fs : reorder some 'struct inode' fields to speedup i_size manipulations Eric Dumazet
2006-11-27 21:37           ` Andrew Morton
2006-11-27 21:52             ` Eric Dumazet
2006-11-27 22:01               ` Andrew Morton
2006-11-28 20:31                 ` Eric Dumazet
2006-11-20 14:23 ` [PATCH -mm 4/4][AIO] - Listio support Sébastien Dugué
2006-11-21 10:35   ` Suparna Bhattacharya
2006-11-27 13:39   ` Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456424D7.7060204@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=hch@infradead.org \
    --cc=jean-pierre.dion@bull.net \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=sebastien.dugue@bull.net \
    --cc=suparna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox