public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Smart <James.Smart@Emulex.Com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-pci@atrey.karlin.mff.cuni.cz, Greg KH <greg@kroah.com>,
	Grant Grundler <grundler@parisc-linux.org>,
	Andrew Morton <akpm@osdl.org>,
	e1000-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: Re: [PATCH 5/5] lpfc : Make Emulex lpfc driver legacy I/O port free
Date: Wed, 22 Nov 2006 10:44:46 -0500	[thread overview]
Message-ID: <4564706E.9060900@emulex.com> (raw)
In-Reply-To: <4564051C.3080908@jp.fujitsu.com>

ACK  :)

(I thought this had already gone in a while ago)

-- james s

Hidetoshi Seto wrote:
> This patch makes Emulex lpfc driver legacy I/O port free.
> 
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> 
> ---
>  drivers/scsi/lpfc/lpfc_init.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 
> Index: linux-2.6.19-rc6/drivers/scsi/lpfc/lpfc_init.c
> ===================================================================
> --- linux-2.6.19-rc6.orig/drivers/scsi/lpfc/lpfc_init.c
> +++ linux-2.6.19-rc6/drivers/scsi/lpfc/lpfc_init.c
> @@ -1453,10 +1453,11 @@
>  	int error = -ENODEV, retval;
>  	int i;
>  	uint16_t iotag;
> +	int bars = pci_select_bars(pdev, IORESOURCE_MEM);
> 
> -	if (pci_enable_device(pdev))
> +	if (pci_enable_device_bars(pdev, bars))
>  		goto out;
> -	if (pci_request_regions(pdev, LPFC_DRIVER_NAME))
> +	if (pci_request_selected_regions(pdev, bars, LPFC_DRIVER_NAME))
>  		goto out_disable_device;
> 
>  	host = scsi_host_alloc(&lpfc_template, sizeof (struct lpfc_hba));
> @@ -1759,7 +1760,7 @@
>  	phba->host = NULL;
>  	scsi_host_put(host);
>  out_release_regions:
> -	pci_release_regions(pdev);
> +	pci_release_selected_regions(pdev, bars);
>  out_disable_device:
>  	pci_disable_device(pdev);
>  out:
> @@ -1773,6 +1774,7 @@
>  	struct Scsi_Host   *host = pci_get_drvdata(pdev);
>  	struct lpfc_hba    *phba = (struct lpfc_hba *)host->hostdata;
>  	unsigned long iflag;
> +	int bars = pci_select_bars(pdev, IORESOURCE_MEM);
> 
>  	lpfc_free_sysfs_attr(phba);
> 
> @@ -1816,7 +1818,7 @@
>  	iounmap(phba->ctrl_regs_memmap_p);
>  	iounmap(phba->slim_memmap_p);
> 
> -	pci_release_regions(phba->pcidev);
> +	pci_release_selected_regions(phba->pcidev, bars);
>  	pci_disable_device(phba->pcidev);
> 
>  	idr_remove(&lpfc_hba_index, phba->brd_no);
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2006-11-22 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22  8:06 [PATCH 5/5] lpfc : Make Emulex lpfc driver legacy I/O port free Hidetoshi Seto
2006-11-22 15:44 ` James Smart [this message]
2007-01-03 22:06   ` James Bottomley
2007-01-03 22:23     ` Andrew Morton
2007-01-03 22:28       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4564706E.9060900@emulex.com \
    --to=james.smart@emulex.com \
    --cc=akpm@osdl.org \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=grundler@parisc-linux.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linux-scsi@vger.kernel.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox