Re: [PATCH] x86_64: fix build without HOTPLUG_CPU (was Re: 2.6.19-rc6-mm1)

Andi Kleen
2006-11-23T15:27:39Z

On Thu, Nov 23, 2006 at 04:17:00PM +0100, Jiri Kosina wrote:
> On Thu, 23 Nov 2006, Andi Kleen wrote:
>
> > > cpu_vsyscall_notifier() is defined only when CONFIG_HOTPLUG_CPU is
> > > defined.
> > It's already long fixed in Linus' tree (in
> > 6b3d1a95ba714bfb1cc81362f7f3e01b7654b4f3) I wonder why that didn't
> > makeit into Andrew's. Andrew, time to update your linus-patch?
>
> Well, is it really? 6b3d1a95ba714bfb1cc81362f7f3e01b7654b4f3 adds the
> ifdef around the cpu_vsyscall_notifier() declaration, but later it's
> passed as parameter to hotcpu_notifier() unconditionally. This is fixed by
> the patch I sent.

hotcpu_notifier is a macro that expands to nothing for !CONFIG_HOTPLUG_CPU

-Andi