From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swamil Jain <s-jain1@ti.com>, Rob Herring <robh@kernel.org>
Cc: jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com,
airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, krzk+dt@kernel.org, conor+dt@kernel.org,
devarsht@ti.com, praneeth@ti.com, bb@ti.com, vigneshr@ti.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support
Date: Thu, 5 Feb 2026 14:27:08 +0100 [thread overview]
Message-ID: <45665c07-858a-4229-8dc9-d5db5470b95f@kernel.org> (raw)
In-Reply-To: <0711169f-6054-44c1-9039-1b56e68c32e0@ti.com>
On 30/01/2026 07:04, Swamil Jain wrote:
>>>>> + properties:
>>>>> + reg-names:
>>>>> + items:
>>>>> + - const: common
>>>>> + - const: vidl1
>>>>> + - const: vid
>>>>> + - const: ovr1
>>>>> + - const: ovr2
>>>>> + - const: vp1
>>>>> + - const: vp2
>>>>> + - const: common1
>>>>
>>>> Why are you defining the names twice?
>>>>
>>>
>>> For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
>>> Could you please suggest a better way?
>>
>> You already defined them at the top level. Here in the if/then schema,
>> all you need is 'maxItems: 5' and 'minItems: 8'. But then you already
>> have that as well.
>>
>> Rob
>
> Posted a v2[1], could you please review if the patch looks good?
>
> [1]: https://lore.kernel.org/all/20260129150601.185882-1-s-jain1@ti.com/
It is not good. Rob asked you what to do. Read his second sentence. You
posted something completely different ignoring what he asked you. Also
ignoring rules stated in the docs.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-02-05 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 13:31 [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support Swamil Jain
2025-12-30 2:27 ` Rob Herring
2025-12-30 14:22 ` Swamil Jain
2026-01-02 22:34 ` Rob Herring
2026-01-16 5:51 ` Swamil Jain
2026-01-30 6:04 ` Swamil Jain
2026-02-05 13:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45665c07-858a-4229-8dc9-d5db5470b95f@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox