From: Andy Whitcroft <apw@shadowen.org>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
Artiom Myaskouvskey <artiom.myaskouvskey@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi_limit_regions triggers link failure when CONFIG_EFI is not defined
Date: Fri, 24 Nov 2006 17:24:24 +0000 [thread overview]
Message-ID: <45672AC8.2010303@shadowen.org> (raw)
In-Reply-To: <200611241805.45621.ak@suse.de>
Andi Kleen wrote:
> On Friday 24 November 2006 17:59, Andy Whitcroft wrote:
>> The following patch is needed to get 2.6.19-rc6-mm1 to compile with
>> CONFIG_EFI disabled. This is the 'shortest' fix. However, it does
>> appear that there is some overlap with EFI implmentation partly
>> being in e820.c and partly in efi.c. It might make sense to move
>> everything efi related over to efi.c.
>
> It compiles here. And the ifdef status hasn't changed at all.
Right, when it was in the function directly the optimiser seems to have
lopped it off nice and early and got rid of the link failure.
> Ah maybe your compiler failed to inline the function so the compiler
> couldn't optimize it away. What compiler were you using? Does it
> go away if you add a "inline" to efi_limit_regions()?
Compiler is as below:
gcc version 3.3.4 (Debian 1:3.3.4-3)
Yes, making efi_limit_regions() inline also seems to work. Can we
guarentee it will be inlined though? I had the feeling that inline was
advisory and if it does not inline then we will get the link failures.
-apw
next prev parent reply other threads:[~2006-11-24 17:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 10:17 2.6.19-rc6-mm1 Andrew Morton
2006-11-23 10:38 ` 2.6.19-rc6-mm1 Reuben Farrelly
2006-11-23 14:06 ` [PATCH] x86_64: fix build without HOTPLUG_CPU (was Re: 2.6.19-rc6-mm1) Jiri Kosina
2006-11-23 15:08 ` Andi Kleen
2006-11-23 15:17 ` Jiri Kosina
2006-11-23 15:27 ` Andi Kleen
2006-11-23 15:37 ` Jiri Kosina
2006-11-23 16:33 ` Ingo Molnar
2006-11-23 11:23 ` 2.6.19-rc6-mm1 Mariusz Kozlowski
2006-11-23 18:36 ` 2.6.19-rc6-mm1 Andrew Morton
2006-11-23 19:24 ` 2.6.19-rc6-mm1 Mariusz Kozlowski
2006-11-23 20:20 ` 2.6.19-rc6-mm1 Andy Whitcroft
2006-11-23 20:56 ` 2.6.19-rc6-mm1 Andrew Morton
2006-11-24 19:34 ` 2.6.19-rc6-mm1 Matthew Frost
2006-11-23 20:23 ` 2.6.19-rc6-mm1 Benoit Boissinot
2006-11-23 12:22 ` 2.6.19-rc6-mm1 Mariusz Kozlowski
2006-11-23 13:03 ` 2.6.19-rc6-mm1 Andy Whitcroft
2006-11-23 17:26 ` MCORE2 include/asm/module.h:60:2: error: #error unknown processor family [was Re: 2.6.19-rc6-mm1] Mattia Dongili
2006-11-23 23:30 ` 2.6.19-rc6-mm1: no help text for TCP_MD5SIG_DEBUG Adrian Bunk
2006-11-24 1:37 ` David Miller
2006-11-24 0:17 ` 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code Adrian Bunk
2006-11-27 18:24 ` Stephen Hemminger
2006-11-29 7:36 ` Adrian Bunk
2006-11-29 7:47 ` Andrew Morton
2007-02-20 0:02 ` Adrian Bunk
2007-02-20 21:31 ` Stephen Hemminger
2007-02-20 22:06 ` Adrian Bunk
2006-11-24 1:46 ` [-mm patch] make qla2x00_reg_remote_port() static Adrian Bunk
2006-11-27 17:22 ` Andrew Vasquez
2006-11-24 1:46 ` [-mm patch] make proc_pid_io_accounting() static Adrian Bunk
2006-11-24 1:46 ` [-mm patch] make readahead_debug_level static Adrian Bunk
2006-11-24 16:59 ` [PATCH] efi_limit_regions triggers link failure when CONFIG_EFI is not defined Andy Whitcroft
2006-11-24 17:05 ` Andi Kleen
2006-11-24 17:24 ` Andy Whitcroft [this message]
2006-11-24 17:33 ` Andi Kleen
2006-11-24 21:30 ` Andrew Morton
2006-11-26 2:13 ` Matthew Frost
2006-11-24 17:58 ` [PATCH] x86_64 vsyscall fails to compile when CONFIG_HOTPLUG_CPU is disabled Andy Whitcroft
2006-11-24 18:03 ` Jiri Kosina
2006-11-24 19:11 ` Andi Kleen
2006-11-24 21:58 ` [-mm patch] net/: possible cleanups Adrian Bunk
2006-12-01 1:28 ` David Miller
2006-11-25 19:15 ` [-mm patch] include/linux/bug.h must always #include <linux/module.h> Adrian Bunk
2006-11-25 19:17 ` [-mm patch] fs/stack.c should #include <linux/fs_stack.h> Adrian Bunk
2006-11-25 19:57 ` Josef Sipek
2006-11-25 19:21 ` [-mm patch] fs/reiser4/: more possible cleanups Adrian Bunk
2006-11-25 19:48 ` 2.6.19-rc6-mm1 -- sched-improve-migration-accuracy.patch slows boot Don Mullis
2006-11-26 6:24 ` Mike Galbraith
2006-11-27 1:38 ` Don Mullis
2006-11-27 10:16 ` Ingo Molnar
2006-11-28 18:47 ` Don Mullis
2006-11-27 10:50 ` [patch] " Mike Galbraith
2006-11-27 17:17 ` Don Mullis
2006-11-27 18:27 ` Mike Galbraith
2006-11-26 5:40 ` [-mm patch] sound/soc/soc-dapm.c: make 4 functions static Adrian Bunk
2006-11-27 4:21 ` [PATCH] paravirt reorder functions to avoid unspecified behaviour Andy Whitcroft
2006-11-27 11:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45672AC8.2010303@shadowen.org \
--to=apw@shadowen.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=artiom.myaskouvskey@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox