From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757373AbWK0I3X (ORCPT ); Mon, 27 Nov 2006 03:29:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757377AbWK0I3X (ORCPT ); Mon, 27 Nov 2006 03:29:23 -0500 Received: from public.id2-vpn.continvity.gns.novell.com ([195.33.99.129]:11957 "EHLO emea1-mh.id2.novell.com") by vger.kernel.org with ESMTP id S1757373AbWK0I3W (ORCPT ); Mon, 27 Nov 2006 03:29:22 -0500 Message-Id: <456AB03F.76E4.0078.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 7.0.1 Date: Mon, 27 Nov 2006 08:30:39 +0000 From: "Jan Beulich" To: "Dave Jones" Cc: "Zwane Mwaikambo" , "Michael Buesch" , "Metathronius Galabant" , , "Michael Krufky" , "Justin Forbes" , , "Theodore Ts'o" , "Chris Wedgwood" , , , "Chuck Wolber" , "Chris Wright" , "Greg Kroah-Hartman" , , "Randy Dunlap" Subject: Re: [stable] [PATCH 46/61] fix Intel RNG detection References: <20061101053340.305569000@sous-sol.org> <20061101054343.623157000@sous-sol.org> <20061120234535.GD17736@redhat.com> <20061121022109.GF1397@sequoia.sous-sol.org> <4562D5DA.76E4.0078.0@novell.com> <20061122015046.GI1397@sequoia.sous-sol.org> <45640FF4.76E4.0078.0@novell.com> <20061124202729.GC29264@redhat.com> In-Reply-To: <20061124202729.GC29264@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >>> Dave Jones 24.11.06 21:27 >>> >On Wed, Nov 22, 2006 at 08:53:08AM +0100, Jan Beulich wrote: > > >It does appear to work w/out the patch. I've asked for a small bit > > >of diagnostics (below), perhaps you've got something you'd rather see? > > >I expect this to be a 24C0 LPC Bridge. > > > > Yes, that's what I'd have asked for. If it works, I expect the device > > code to be different, or both manufacturer and device code to be > > invalid. Depending on the outcome, perhaps we'll need an override > > option so that this test can be partially (i.e. just the device code > > part) or entirely (all the FWH detection) skipped. > > The base problem is the vague documentation of the whole > > detection mechanism - a lot of this I had to read between the lines. > >The bug report I referenced came back with this from that debug patch.. > >intel_rng: no version for "struct_module" found: kernel tainted. >intel_rng: pci vendor:device 8086:24c0 fwh_dec_en1 80 bios_cntl_val 2 mfc cb dvc 88 >intel_rng: FWH not detected Okay, this means the lock is being set by the BIOS, which disallows disabling BIOS (and thus accessing the FWH). By default, I think it is correct to consider the RNG not present in this case, however as previously indicated I think we should provide a way to force skipping the FWH test (with three levels - carry out, skip always, or skip if BIOS locked). I'll prepare a patch as soon as I can, but it might take a few days until I get to it. Jan