From: Anderson Briglia <anderson.briglia@indt.org.br>
To: ext Pierre Ossman <drzeus-list@drzeus.cx>
Cc: "Linux-omap-open-source@linux.omap.com"
<linux-omap-open-source@linux.omap.com>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@indt.org.br>,
ext David Brownell <david-b@pacbell.net>,
"Lizardo Anderson (EXT-INdT/Manaus)"
<anderson.lizardo@indt.org.br>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 3/5] [RFC] Add MMC Password Protection (lock/unlock) support V7: mmc_lock_unlock.diff
Date: Mon, 27 Nov 2006 09:45:58 -0400 [thread overview]
Message-ID: <456AEC16.3010009@indt.org.br> (raw)
In-Reply-To: <45680308.4040809@drzeus.cx>
ext Pierre Ossman wrote:
> Anderson Briglia wrote:
>> @@ -244,5 +244,13 @@ struct _mmc_csd {
>> #define SD_BUS_WIDTH_1 0
>> #define SD_BUS_WIDTH_4 2
>>
>> +/*
>> + * MMC_LOCK_UNLOCK modes
>> + */
>> +#define MMC_LOCK_MODE_ERASE (1<<3)
>> +#define MMC_LOCK_MODE_UNLOCK (0<<2)
>> +#define MMC_LOCK_MODE_CLR_PWD (1<<1)
>> +#define MMC_LOCK_MODE_SET_PWD (1<<0)
>> +
>> #endif /* MMC_MMC_PROTOCOL_H */
>>
>
> This definition makes them look like bits, which is not how they are used.
How can I improve this? Defining using integers directly?
>
> Rgds
>
next prev parent reply other threads:[~2006-11-27 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 14:51 [patch 3/5] [RFC] Add MMC Password Protection (lock/unlock) support V7: mmc_lock_unlock.diff Anderson Briglia
2006-11-25 8:47 ` Pierre Ossman
2006-11-27 13:45 ` Anderson Briglia [this message]
2006-12-01 21:20 ` Pierre Ossman
2006-12-04 18:45 ` Anderson Briglia
2006-12-04 20:23 ` Pierre Ossman
2006-12-05 18:06 ` Anderson Briglia
2006-11-25 8:53 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456AEC16.3010009@indt.org.br \
--to=anderson.briglia@indt.org.br \
--cc=anderson.lizardo@indt.org.br \
--cc=carlos.aguiar@indt.org.br \
--cc=david-b@pacbell.net \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox