[2.6 patch] remove the broken VIDEO_ZR36120 driver

[2.6 patch] remove the broken VIDEO_ZR36120 driver

[Adrian Bunk]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

The VIDEO_ZR36120 driver has:
- already been marked as BROKEN in 2.6.0 three years ago and
- is still marked as BROKEN.

Drivers that had been marked as BROKEN for such a long time seem to be 
unlikely to be revived in the forseeable future.

But if anyone wants to ever revive this driver, the code is still 
present in the older kernel releases.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>

---

This patch was already sent on:
- 18 Nov 2006

Due to it's size, the patch is attached compressed.

 Documentation/video4linux/zr36120.txt |  162 --
 drivers/media/video/Kconfig           |   12 
 drivers/media/video/Makefile          |    2 
 drivers/media/video/zr36120.c         | 2079 --------------------------
 drivers/media/video/zr36120.h         |  279 ---
 drivers/media/video/zr36120_i2c.c     |  132 -
 drivers/media/video/zr36120_mem.c     |   78 
 drivers/media/video/zr36120_mem.h     |    3 
 8 files changed, 2747 deletions(-)


[-- Attachment #2: patch-remove-broken-VIDEO_ZR36120.gz --]
[-- Type: application/octet-stream, Size: 23820 bytes --]

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Mauro Carvalho Chehab]

Em Sáb, 2006-11-25 às 20:15 +0100, Adrian Bunk escreveu:
> The VIDEO_ZR36120 driver has:
> - already been marked as BROKEN in 2.6.0 three years ago and
> - is still marked as BROKEN.
> 
> Drivers that had been marked as BROKEN for such a long time seem to be 
> unlikely to be revived in the forseeable future.
> 
> But if anyone wants to ever revive this driver, the code is still 
> present in the older kernel releases.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>

Ok, applied at my -git. 

Cheers, 
Mauro.

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Joe Feise]

Adrian Bunk wrote on 11/25/06 11:15:

> The VIDEO_ZR36120 driver has:
> - already been marked as BROKEN in 2.6.0 three years ago and
> - is still marked as BROKEN.
> 
> Drivers that had been marked as BROKEN for such a long time seem to be 
> unlikely to be revived in the forseeable future.
> 
> But if anyone wants to ever revive this driver, the code is still 
> present in the older kernel releases.

Hmm, there are people out there (like me) who still use it and have patched it
to get it working on 2.6.x.

-Joe

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Adrian Bunk]

On Mon, Nov 27, 2006 at 09:30:27PM -0800, Joe Feise wrote:
> Adrian Bunk wrote on 11/25/06 11:15:
> 
> > The VIDEO_ZR36120 driver has:
> > - already been marked as BROKEN in 2.6.0 three years ago and
> > - is still marked as BROKEN.
> > 
> > Drivers that had been marked as BROKEN for such a long time seem to be 
> > unlikely to be revived in the forseeable future.
> > 
> > But if anyone wants to ever revive this driver, the code is still 
> > present in the older kernel releases.
> 
> Hmm, there are people out there (like me) who still use it and have patched it
> to get it working on 2.6.x.

If you anyway have to patch your kernel, you can as well patch the 
complete driver into the kernel.

Three years after 2.6.0 the in-kernel driver is still marked as BROKEN, 
and e.g. the current Video4Linux API change might leave this driver 
unfixed and even more broken.

Is anyone working on getting this driver into shape NOW?
If not, it will still be at any time possible to submit a fixed version 
of this driver for re-inclusion.

> -Joe

cu
Adrian

BTW: Please don't drop people from the Cc.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Joe Feise]

Adrian Bunk wrote on 11/27/06 22:07:

> On Mon, Nov 27, 2006 at 09:30:27PM -0800, Joe Feise wrote:
>> Adrian Bunk wrote on 11/25/06 11:15:
>>
>>> The VIDEO_ZR36120 driver has:
>>> - already been marked as BROKEN in 2.6.0 three years ago and
>>> - is still marked as BROKEN.
>>>
>>> Drivers that had been marked as BROKEN for such a long time seem to be 
>>> unlikely to be revived in the forseeable future.
>>>
>>> But if anyone wants to ever revive this driver, the code is still 
>>> present in the older kernel releases.
>> Hmm, there are people out there (like me) who still use it and have patched it
>> to get it working on 2.6.x.
> 
> If you anyway have to patch your kernel, you can as well patch the 
> complete driver into the kernel.


Well, there are other things outside the actual driver code that may change, and
that would make it harder to keep my patch in sync.
And actually, I submitted my patch some time ago to the maintainer of the driver
(Pauline Middelink.) Unfortunately, it never made it into the kernel, nor did I
get any feedback from her. I have no idea if she is still active (she is listed
as maintainer at least until 2.6.17.) I cc'ed her on this mail.

-Joe

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Mauro Carvalho Chehab]

Hi Joe,

Em Seg, 2006-11-27 às 22:36 -0800, Joe Feise escreveu:
> Adrian Bunk wrote on 11/27/06 22:07:
> 
> > On Mon, Nov 27, 2006 at 09:30:27PM -0800, Joe Feise wrote:
> >> Adrian Bunk wrote on 11/25/06 11:15:
> >>
> >>> But if anyone wants to ever revive this driver, the code is still 
> >>> present in the older kernel releases.
> >> Hmm, there are people out there (like me) who still use it and have patched it
> >> to get it working on 2.6.x.
> > If you anyway have to patch your kernel, you can as well patch the 
> > complete driver into the kernel.
> Well, there are other things outside the actual driver code that may change, and
> that would make it harder to keep my patch in sync.
Keeping it in sync is not hard. Most changes are just small API changes
that are easy to port to all drivers, since they all behave likely.
Also, when kernel hackers changes API, they usually send patches fixing
API also at the affected drivers (of course for not-broken stuff).
> And actually, I submitted my patch some time ago to the maintainer of the driver
> (Pauline Middelink.)  Unfortunately, it never made it into the kernel, nor did I
> get any feedback from her. I have no idea if she is still active (she is listed
> as maintainer at least until 2.6.17.) I cc'ed her on this mail.
If you are interested on fixing this driver, you may submit the fix
patch to me, with your SOB. I'm maintaining the V4L subsystem as a hole.
> 
> 
> -Joe
> 
> 
Cheers, 
Mauro.

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Peter Schlaf]

Mauro Carvalho Chehab schrieb:
> Hi Joe,
> 
> Em Seg, 2006-11-27 às 22:36 -0800, Joe Feise escreveu:
>> Adrian Bunk wrote on 11/27/06 22:07:
>>
>>> On Mon, Nov 27, 2006 at 09:30:27PM -0800, Joe Feise wrote:
>>>> Adrian Bunk wrote on 11/25/06 11:15:
>>>>
>>>>> But if anyone wants to ever revive this driver, the code is still 
>>>>> present in the older kernel releases.
>>>> Hmm, there are people out there (like me) who still use it and have patched it
>>>> to get it working on 2.6.x.
>>> If you anyway have to patch your kernel, you can as well patch the 
>>> complete driver into the kernel.
>> Well, there are other things outside the actual driver code that may change, and
>> that would make it harder to keep my patch in sync.
> Keeping it in sync is not hard. Most changes are just small API changes
> that are easy to port to all drivers, since they all behave likely.
> Also, when kernel hackers changes API, they usually send patches fixing
> API also at the affected drivers (of course for not-broken stuff).
>> And actually, I submitted my patch some time ago to the maintainer of the driver
>> (Pauline Middelink.)  Unfortunately, it never made it into the kernel, nor did I
>> get any feedback from her. I have no idea if she is still active (she is listed
>> as maintainer at least until 2.6.17.) I cc'ed her on this mail.
> If you are interested on fixing this driver, you may submit the fix
> patch to me, with your SOB. I'm maintaining the V4L subsystem as a hole.
>>
>> -Joe
>>
>>
> Cheers, 
> Mauro.

Hello,

I would like to see this driver fixed and remaining in the kernel and
would give any support I can to achive this goal.

I have a zr36120 based tv card and wrote a driver on my own based on
this kernel driver from Pauline Middelink. Maybe it could be helpful.

CU
Peter

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Pauline Middelink]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Tue, 28 Nov 2006 around 20:11:35 +0100, Peter Schlaf wrote:
> Hello,
> 
> I would like to see this driver fixed and remaining in the kernel and
> would give any support I can to achive this goal.
> 
> I have a zr36120 based tv card and wrote a driver on my own based on
> this kernel driver from Pauline Middelink. Maybe it could be helpful.

I would have no problem Peter taking over the maintainance of the driver.
Due to timeconstrains I no longer have the time to upgrade the driver
to v4l2 (which is a bigger problem than getting the current driver to 
run under 2.6)

    Met vriendelijke groet,
        Pauline Middelink
-- 
GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA  BD3B 9A50 B416 E2D0 C3C2
For more details look at my website http://www.polyware.nl/~middelink

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2302 bytes --]

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Peter Schlaf]

Pauline Middelink schrieb:
> On Tue, 28 Nov 2006 around 20:11:35 +0100, Peter Schlaf wrote:
>> Hello,
>>
>> I would like to see this driver fixed and remaining in the kernel and
>> would give any support I can to achive this goal.
>>
>> I have a zr36120 based tv card and wrote a driver on my own based on
>> this kernel driver from Pauline Middelink. Maybe it could be helpful.
> 
> I would have no problem Peter taking over the maintainance of the driver.
> Due to timeconstrains I no longer have the time to upgrade the driver
> to v4l2 (which is a bigger problem than getting the current driver to 
> run under 2.6)

Hi,

I can maintain the driver, if there is no objection.

But this driver only, not the bigphysarea patch.

CU
Peter

Re: [2.6 patch] remove the broken VIDEO_ZR36120 driver

[Alan]

> Hmm, there are people out there (like me) who still use it and have patched it
> to get it working on 2.6.x.

If the maintainer has vanished can you post the patches here instead for
review ?