From: Arjan van de Ven <arjan@linux.intel.com>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch] Mark rdtsc as sync only for netburst, not for core2
Date: Wed, 29 Nov 2006 08:30:52 +0100 [thread overview]
Message-ID: <456D372C.9080800@linux.intel.com> (raw)
In-Reply-To: <1164774239.15257.5.camel@ymzhang>
Zhang, Yanmin wrote:
> If it's a single processor, the go backwards issue doesn't exist. Below is
> my patch based on Arjan's. It's against 2.6.19-rc5-mm2.
Hi,
this patch is incorrect
> --- linux-2.6.19-rc5-mm2_arjan/arch/x86_64/kernel/setup.c 2006-11-29 10:41:21.000000000 +0800
> +++ linux-2.6.19-rc5-mm2_arjan_fix/arch/x86_64/kernel/setup.c 2006-11-29 10:42:28.000000000 +0800
> @@ -861,7 +861,7 @@ static void __cpuinit init_intel(struct
> set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability);
> if (c->x86 == 6)
> set_bit(X86_FEATURE_REP_GOOD, &c->x86_capability);
> - if (c->x86 == 15)
> + if (c->x86 == 15 && num_possible_cpus() != 1)
> set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
first of all, you probably meant "|| num_possible_cpus() == 1"
but second of all, the core2 cpus are dual core so.. .what does it
bring you at all?
next prev parent reply other threads:[~2006-11-29 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 10:28 [patch] Mark rdtsc as sync only for netburst, not for core2 Arjan van de Ven
2006-11-28 10:36 ` Andi Kleen
[not found] ` <1164774239.15257.5.camel@ymzhang>
2006-11-29 7:30 ` Arjan van de Ven [this message]
2006-11-29 8:05 ` Nick Piggin
2006-11-29 9:04 ` Zhang, Yanmin
[not found] ` <1164787104.2899.7.camel@ymzhang>
2006-11-29 8:35 ` Arjan van de Ven
2006-11-29 9:07 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456D372C.9080800@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox