From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935845AbWK2QPQ (ORCPT ); Wed, 29 Nov 2006 11:15:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935847AbWK2QPQ (ORCPT ); Wed, 29 Nov 2006 11:15:16 -0500 Received: from rgminet01.oracle.com ([148.87.113.118]:30095 "EHLO rgminet01.oracle.com") by vger.kernel.org with ESMTP id S935846AbWK2QPO (ORCPT ); Wed, 29 Nov 2006 11:15:14 -0500 Message-ID: <456DB203.1090108@oracle.com> Date: Wed, 29 Nov 2006 08:14:59 -0800 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Jiri Slaby CC: lkml , akpm Subject: Re: [PATCH -mm] char: drivers use/need PCI References: <20061128211203.fa197b15.randy.dunlap@oracle.com> <456D4033.5000202@gmail.com> In-Reply-To: <456D4033.5000202@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jiri Slaby wrote: > Randy Dunlap wrote: >> From: Randy Dunlap >> >> With CONFIG_PCI=n: >> drivers/char/mxser_new.c: In function 'mxser_release_res': >> drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region' >> drivers/char/mxser_new.c: In function 'mxser_probe': >> drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region' >> drivers/built-in.o: In function `sx_remove_card': >> sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region' >> drivers/char/isicom.c: In function 'isicom_probe': >> drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region' >> drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region' >> >> Signed-off-by: Randy Dunlap >> --- >> drivers/char/Kconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> --- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig >> +++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig >> @@ -203,7 +203,7 @@ config MOXA_SMARTIO >> >> config MOXA_SMARTIO_NEW >> tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)" >> - depends on SERIAL_NONSTANDARD >> + depends on SERIAL_NONSTANDARD && PCI >> help >> Say Y here if you have a Moxa SmartIO multiport serial card and/or >> want to help develop a new version of this driver. >> @@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW >> >> config ISI >> tristate "Multi-Tech multiport card support (EXPERIMENTAL)" >> - depends on SERIAL_NONSTANDARD >> + depends on SERIAL_NONSTANDARD && PCI >> select FW_LOADER >> help >> This is a driver for the Multi-Tech cards which provide several >> @@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS >> >> config SX >> tristate "Specialix SX (and SI) card support" >> - depends on SERIAL_NONSTANDARD >> + depends on SERIAL_NONSTANDARD && PCI >> help >> This is a driver for the SX and SI multiport serial cards. >> Please read the file for details. > > Nack. I have to correct the mxser and sx code. Thanks, Sure, either way is OK. Thanks. -- ~Randy