* [PATCH -mm] char: drivers use/need PCI
@ 2006-11-29 5:12 Randy Dunlap
2006-11-29 8:09 ` Jiri Slaby
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2006-11-29 5:12 UTC (permalink / raw)
To: lkml; +Cc: akpm, jirislaby
From: Randy Dunlap <randy.dunlap@oracle.com>
With CONFIG_PCI=n:
drivers/char/mxser_new.c: In function 'mxser_release_res':
drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region'
drivers/char/mxser_new.c: In function 'mxser_probe':
drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region'
drivers/built-in.o: In function `sx_remove_card':
sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region'
drivers/char/isicom.c: In function 'isicom_probe':
drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region'
drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/char/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig
+++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig
@@ -203,7 +203,7 @@ config MOXA_SMARTIO
config MOXA_SMARTIO_NEW
tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
- depends on SERIAL_NONSTANDARD
+ depends on SERIAL_NONSTANDARD && PCI
help
Say Y here if you have a Moxa SmartIO multiport serial card and/or
want to help develop a new version of this driver.
@@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
config ISI
tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
- depends on SERIAL_NONSTANDARD
+ depends on SERIAL_NONSTANDARD && PCI
select FW_LOADER
help
This is a driver for the Multi-Tech cards which provide several
@@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
config SX
tristate "Specialix SX (and SI) card support"
- depends on SERIAL_NONSTANDARD
+ depends on SERIAL_NONSTANDARD && PCI
help
This is a driver for the SX and SI multiport serial cards.
Please read the file <file:Documentation/sx.txt> for details.
---
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] char: drivers use/need PCI
2006-11-29 5:12 [PATCH -mm] char: drivers use/need PCI Randy Dunlap
@ 2006-11-29 8:09 ` Jiri Slaby
2006-11-29 16:14 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Slaby @ 2006-11-29 8:09 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> With CONFIG_PCI=n:
> drivers/char/mxser_new.c: In function 'mxser_release_res':
> drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region'
> drivers/char/mxser_new.c: In function 'mxser_probe':
> drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region'
> drivers/built-in.o: In function `sx_remove_card':
> sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region'
> drivers/char/isicom.c: In function 'isicom_probe':
> drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region'
> drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/char/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig
> +++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig
> @@ -203,7 +203,7 @@ config MOXA_SMARTIO
>
> config MOXA_SMARTIO_NEW
> tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
> - depends on SERIAL_NONSTANDARD
> + depends on SERIAL_NONSTANDARD && PCI
> help
> Say Y here if you have a Moxa SmartIO multiport serial card and/or
> want to help develop a new version of this driver.
> @@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
>
> config ISI
> tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
> - depends on SERIAL_NONSTANDARD
> + depends on SERIAL_NONSTANDARD && PCI
> select FW_LOADER
> help
> This is a driver for the Multi-Tech cards which provide several
> @@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
>
> config SX
> tristate "Specialix SX (and SI) card support"
> - depends on SERIAL_NONSTANDARD
> + depends on SERIAL_NONSTANDARD && PCI
> help
> This is a driver for the SX and SI multiport serial cards.
> Please read the file <file:Documentation/sx.txt> for details.
Nack. I have to correct the mxser and sx code. Thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] char: drivers use/need PCI
2006-11-29 8:09 ` Jiri Slaby
@ 2006-11-29 16:14 ` Randy Dunlap
2006-11-29 16:28 ` Jiri Slaby
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2006-11-29 16:14 UTC (permalink / raw)
To: Jiri Slaby; +Cc: lkml, akpm
Jiri Slaby wrote:
> Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> With CONFIG_PCI=n:
>> drivers/char/mxser_new.c: In function 'mxser_release_res':
>> drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region'
>> drivers/char/mxser_new.c: In function 'mxser_probe':
>> drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region'
>> drivers/built-in.o: In function `sx_remove_card':
>> sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region'
>> drivers/char/isicom.c: In function 'isicom_probe':
>> drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region'
>> drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> ---
>> drivers/char/Kconfig | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> --- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig
>> +++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig
>> @@ -203,7 +203,7 @@ config MOXA_SMARTIO
>>
>> config MOXA_SMARTIO_NEW
>> tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
>> - depends on SERIAL_NONSTANDARD
>> + depends on SERIAL_NONSTANDARD && PCI
>> help
>> Say Y here if you have a Moxa SmartIO multiport serial card and/or
>> want to help develop a new version of this driver.
>> @@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
>>
>> config ISI
>> tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
>> - depends on SERIAL_NONSTANDARD
>> + depends on SERIAL_NONSTANDARD && PCI
>> select FW_LOADER
>> help
>> This is a driver for the Multi-Tech cards which provide several
>> @@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
>>
>> config SX
>> tristate "Specialix SX (and SI) card support"
>> - depends on SERIAL_NONSTANDARD
>> + depends on SERIAL_NONSTANDARD && PCI
>> help
>> This is a driver for the SX and SI multiport serial cards.
>> Please read the file <file:Documentation/sx.txt> for details.
>
> Nack. I have to correct the mxser and sx code. Thanks,
Sure, either way is OK. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] char: drivers use/need PCI
2006-11-29 16:14 ` Randy Dunlap
@ 2006-11-29 16:28 ` Jiri Slaby
2006-11-29 16:41 ` Alan
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Slaby @ 2006-11-29 16:28 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm
Randy Dunlap wrote:
> Jiri Slaby wrote:
>> Randy Dunlap wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> With CONFIG_PCI=n:
>>> drivers/char/mxser_new.c: In function 'mxser_release_res':
>>> drivers/char/mxser_new.c:2383: warning: implicit declaration of
>>> function 'pci_release_region'
>>> drivers/char/mxser_new.c: In function 'mxser_probe':
>>> drivers/char/mxser_new.c:2578: warning: implicit declaration of
>>> function 'pci_request_region'
>>> drivers/built-in.o: In function `sx_remove_card':
>>> sx.c:(.text.sx_remove_card+0x65): undefined reference to
>>> `pci_release_region'
>>> drivers/char/isicom.c: In function 'isicom_probe':
>>> drivers/char/isicom.c:1793: warning: implicit declaration of function
>>> 'pci_request_region'
>>> drivers/char/isicom.c:1827: warning: implicit declaration of function
>>> 'pci_release_region'
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> ---
>>> drivers/char/Kconfig | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> --- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig
>>> +++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig
>>> @@ -203,7 +203,7 @@ config MOXA_SMARTIO
>>>
>>> config MOXA_SMARTIO_NEW
>>> tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
>>> - depends on SERIAL_NONSTANDARD
>>> + depends on SERIAL_NONSTANDARD && PCI
>>> help
>>> Say Y here if you have a Moxa SmartIO multiport serial card
>>> and/or
>>> want to help develop a new version of this driver.
>>> @@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
>>>
>>> config ISI
>>> tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
>>> - depends on SERIAL_NONSTANDARD
>>> + depends on SERIAL_NONSTANDARD && PCI
>>> select FW_LOADER
>>> help
>>> This is a driver for the Multi-Tech cards which provide several
>>> @@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
>>>
>>> config SX
>>> tristate "Specialix SX (and SI) card support"
>>> - depends on SERIAL_NONSTANDARD
>>> + depends on SERIAL_NONSTANDARD && PCI
>>> help
>>> This is a driver for the SX and SI multiport serial cards.
>>> Please read the file <file:Documentation/sx.txt> for details.
>>
>> Nack. I have to correct the mxser and sx code. Thanks,
>
> Sure, either way is OK. Thanks.
But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct
temporary way and I'll add "|| ISA" after the proposed code fix :).
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] char: drivers use/need PCI
2006-11-29 16:28 ` Jiri Slaby
@ 2006-11-29 16:41 ` Alan
2006-11-29 16:42 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Alan @ 2006-11-29 16:41 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Randy Dunlap, lkml, akpm
> But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct
> temporary way and I'll add "|| ISA" after the proposed code fix :).
That stops it being built on some platforms that have ISA and not PCI.
Seems a poor fix for what really is a couple of ifdefs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] char: drivers use/need PCI
2006-11-29 16:41 ` Alan
@ 2006-11-29 16:42 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2006-11-29 16:42 UTC (permalink / raw)
To: Alan; +Cc: Jiri Slaby, lkml, akpm
Alan wrote:
>> But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct
>> temporary way and I'll add "|| ISA" after the proposed code fix :).
>
> That stops it being built on some platforms that have ISA and not PCI.
> Seems a poor fix for what really is a couple of ifdefs
They currently won't build for ISA because they always use the pci functions,
so yes, they do need to be fixed (correctly) --> Jiri :)
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-11-29 16:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-29 5:12 [PATCH -mm] char: drivers use/need PCI Randy Dunlap
2006-11-29 8:09 ` Jiri Slaby
2006-11-29 16:14 ` Randy Dunlap
2006-11-29 16:28 ` Jiri Slaby
2006-11-29 16:41 ` Alan
2006-11-29 16:42 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox