public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@cfl.rr.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: reiserfs-dev@namesys.com, reiserfs-list@namesys.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: reiserfs add missing brackets
Date: Thu, 30 Nov 2006 11:22:33 -0500	[thread overview]
Message-ID: <456F0549.2050801@cfl.rr.com> (raw)
In-Reply-To: <200611301038.03140.m.kozlowski@tuxland.pl>

I know it is just nit-picking, but those are parenthesis, not brackets.

() vs. []

Mariusz Kozlowski wrote:
> Hello,
> 
> 	This patch adds missing brackets. 
> 
>  include/linux/reiserfs_fs.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.19-rc6-mm2-a/include/linux/reiserfs_fs.h	2006-11-28 12:17:06.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/include/linux/reiserfs_fs.h	2006-11-30 01:05:38.000000000 +0100
> @@ -739,7 +739,7 @@ struct block_head {
>  #define PUT_B_FREE_SPACE(p_s_bh,val)  do { set_blkh_free_space(B_BLK_HEAD(p_s_bh),val); } while (0)
>  
>  /* Get right delimiting key. -- little endian */
> -#define B_PRIGHT_DELIM_KEY(p_s_bh)   (&(blk_right_delim_key(B_BLK_HEAD(p_s_bh))
> +#define B_PRIGHT_DELIM_KEY(p_s_bh)   (&(blk_right_delim_key(B_BLK_HEAD(p_s_bh))))
>  
>  /* Does the buffer contain a disk leaf. */
>  #define B_IS_ITEMS_LEVEL(p_s_bh)     (B_LEVEL(p_s_bh) == DISK_LEAF_NODE_LEVEL)
> 
> 


      reply	other threads:[~2006-11-30 16:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30  9:38 [PATCH] fs: reiserfs add missing brackets Mariusz Kozlowski
2006-11-30 16:22 ` Phillip Susi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456F0549.2050801@cfl.rr.com \
    --to=psusi@cfl.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.kozlowski@tuxland.pl \
    --cc=reiserfs-dev@namesys.com \
    --cc=reiserfs-list@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox