From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756925AbcBIP2G (ORCPT ); Tue, 9 Feb 2016 10:28:06 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:53639 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbcBIP2D convert rfc822-to-8bit (ORCPT ); Tue, 9 Feb 2016 10:28:03 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Guenter Roeck , Greg Kroah-Hartman , Baruch Siach , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , kernel-testers@vger.kernel.org, Andrzej Hajda Subject: Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE Date: Tue, 09 Feb 2016 16:26:38 +0100 Message-ID: <4571887.rTPndCnv20@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455030539-10798-1-git-send-email-linux@roeck-us.net> References: <1455030539-10798-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:7alPPW6z+hqk5Fx8PixxFqwRYrWFZt94iH8KY+nyAWrdKKOiPCC wDekZZO8fL1/MrNMryOKquSfVGz1s8Y5RaPO78m0NkqijjEI4ts7WEmRaauRNUzAr/UDGOF ITtsVjBRdbBI2Wz5aIt64luUa6IJjFU9SkpndOWD5sI5wMe02haBY73QFpW7rhb8RXBTD0E DuDyM8UqujgISyIe3LldA== X-UI-Out-Filterresults: notjunk:1;V01:K0:KdsFaGOROX0=:P9Zq8WkRTUnO0G3T9gd4cl INaezRabXsaBLWAZA1DIyTo1OXOsYzRlEGzLM2vNjrqwSyQgUKVyBKZ7Bvt9bTZulTSunrHiP kOruc4tM1LzbVG3BuaFrB9Wn/hEyCBVwy4GedluCqsQ+hkadzk1ldXYbZsE+nWSbcsIKQBeeB RBL/NHvegtzjJ7A4prQ0mGpETZQTmat74q0xA/n5rTGdI78rbENq3cMFkGKityGJm9usKFnBP t/PYtZ0NSzPO1e9gNYZlUpKc3gjTvNAtzAH9vhx8SSOiagrrIPKvd8ZQ0gn+tkOZTEFP8omX1 fCT8oydPJOn6tvXmv9KUuHSjUShKxTWnsmZRHP2GaBgXnt5C3xPfYuzbdXj6fbsBSV9f0+kiw GXMIsJMr1N28s0hxuag32+t6+3yFUl9XEECi9avvVRk0Aay6bqo/Ijh4RWIpWmgX4lk9T6xN/ 6LHBgVvNHkzZ0TEJPgKWu7zFW45zv/lrjpboARQ8MyuCyhEsidD9ssgTnM/hO9g1lldQvaEG9 Ja9gjzZBhSfMJqEoVmqK4A15wlvPZk81n3RZ0XXfoASRVPvin4GC0fAJiHEr1zrt8DzOuTbOm FRFZezD5qqwFIBhAtym9MtJAfXdOIosXPt7lSrs69qF5sG6tExcA5qIRtw5WrLMXUfZmtm3v2 9vIBs4DHWjNB5s32IghnfxZS2vBbHt8W5PisYANqqXz61IidHp+ftKe3Prf8lmFBhIDXem55H ndkFQlVfIlbaZp2Q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an unsigned int reflects an error. > Doing so can result in the following build warning. > > drivers/tty/serial/digicolor-usart.c: In function ‘digicolor_uart_probe’: > include/linux/err.h:21:38: warning: > comparison is always false due to limited range of data type > drivers/tty/serial/digicolor-usart.c:485:6: note: > in expansion of macro ‘IS_ERR_VALUE’ > > If that warning is seen, an error return from platform_get_irq() is missed. > > The patch looks correct to me, but what compiler version and which kernel tree is it that triggered the warning? Andrzej Hajda just modified the definition of IS_ERR_VALUE(), and the changes are still under discussion, but I don't see that warning with any of the versions. Arnd