Re: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT

[Randy Dunlap <randy.dunlap@oracle.com>]

Adrian Bunk wrote:
> On Tue, Nov 28, 2006 at 04:45:38PM -0800, Andrew Morton wrote:
>> On Tue, 28 Nov 2006 14:08:40 -0800
>> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> NTFS (=m) uses hweight32(), but that function is only linked
>>> into the kernel image if it is used inside the kernel image,
>>> not in loadable modules.  Let modules force HWEIGHT to be
>>> built into the kernel image.  Otherwise build fails:
>>>
>>>   Building modules, stage 2.
>>>   MODPOST 94 modules
>>> WARNING: "hweight32" [fs/ntfs/ntfs.ko] undefined!
>>>
>>> Yes, I'd certainly prefer for this to be more automated rather than
>>> forced by each module that needs it.
>> Perhaps we should just put it in lib-y and remove CONFIG_GENERIC_HWEIGHT.
>> ...
> 
> This will obviously not help in this case...
> 
> EXPORT_SYMBOL() in a lib-* is always a bug.

so I changed hweight.o to always be in obj-y instead of lib-y.

-- 
~Randy